From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v9] mm: support madvise(MADV_FREE) Date: Thu, 3 Jul 2014 10:03:19 +0900 Message-ID: <20140703010318.GA2939@bbox> References: <1404174975-22019-1-git-send-email-minchan@kernel.org> <20140701145058.GA2084@node.dhcp.inet.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20140701145058.GA2084-nhfs4B5ZimeFUdmeq17FyvUpdFzICT1y@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei List-Id: linux-api@vger.kernel.org Hello, On Tue, Jul 01, 2014 at 05:50:58PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 01, 2014 at 09:36:15AM +0900, Minchan Kim wrote: > > + do { > > + /* > > + * XXX: We can optimize with supporting Hugepage free > > + * if the range covers. > > + */ > > + next = pmd_addr_end(addr, end); > > + if (pmd_trans_huge(*pmd)) > > + split_huge_page_pmd(vma, addr, pmd); > > Could you implement proper THP support before upstreaming the feature? > It shouldn't be a big deal. Okay, Hope to review. Thanks for the feedback! -- Kind regards, Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by kanga.kvack.org (Postfix) with ESMTP id 87A0E6B0035 for ; Wed, 2 Jul 2014 21:01:59 -0400 (EDT) Received: by mail-lb0-f170.google.com with SMTP id 10so8649702lbg.1 for ; Wed, 02 Jul 2014 18:01:58 -0700 (PDT) Received: from lgeamrelo04.lge.com (lgeamrelo04.lge.com. [156.147.1.127]) by mx.google.com with ESMTP id w1si23317457laa.1.2014.07.02.18.01.56 for ; Wed, 02 Jul 2014 18:01:58 -0700 (PDT) Date: Thu, 3 Jul 2014 10:03:19 +0900 From: Minchan Kim Subject: Re: [PATCH v9] mm: support madvise(MADV_FREE) Message-ID: <20140703010318.GA2939@bbox> References: <1404174975-22019-1-git-send-email-minchan@kernel.org> <20140701145058.GA2084@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140701145058.GA2084@node.dhcp.inet.fi> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei Hello, On Tue, Jul 01, 2014 at 05:50:58PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 01, 2014 at 09:36:15AM +0900, Minchan Kim wrote: > > + do { > > + /* > > + * XXX: We can optimize with supporting Hugepage free > > + * if the range covers. > > + */ > > + next = pmd_addr_end(addr, end); > > + if (pmd_trans_huge(*pmd)) > > + split_huge_page_pmd(vma, addr, pmd); > > Could you implement proper THP support before upstreaming the feature? > It shouldn't be a big deal. Okay, Hope to review. Thanks for the feedback! -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753828AbaGCBB6 (ORCPT ); Wed, 2 Jul 2014 21:01:58 -0400 Received: from lgeamrelo04.lge.com ([156.147.1.127]:50205 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbaGCBB4 (ORCPT ); Wed, 2 Jul 2014 21:01:56 -0400 X-Original-SENDERIP: 10.177.220.169 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 3 Jul 2014 10:03:19 +0900 From: Minchan Kim To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei Subject: Re: [PATCH v9] mm: support madvise(MADV_FREE) Message-ID: <20140703010318.GA2939@bbox> References: <1404174975-22019-1-git-send-email-minchan@kernel.org> <20140701145058.GA2084@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140701145058.GA2084@node.dhcp.inet.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Jul 01, 2014 at 05:50:58PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 01, 2014 at 09:36:15AM +0900, Minchan Kim wrote: > > + do { > > + /* > > + * XXX: We can optimize with supporting Hugepage free > > + * if the range covers. > > + */ > > + next = pmd_addr_end(addr, end); > > + if (pmd_trans_huge(*pmd)) > > + split_huge_page_pmd(vma, addr, pmd); > > Could you implement proper THP support before upstreaming the feature? > It shouldn't be a big deal. Okay, Hope to review. Thanks for the feedback! -- Kind regards, Minchan Kim