From: Lee Jones <lee.jones@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
"Mark Brown" <broonie@kernel.org>,
"Vincent Palatin" <vpalatin@chromium.org>,
"Bill Richardson" <wfrichar@chromium.org>,
"Randall Spangler" <rspangler@chromium.org>,
"Simon Glass" <sjg@chromium.org>,
"Andreas Färber" <afaerber@suse.de>,
"Stephan van Schaik" <stephan@synkhronix.com>,
"Olof Johansson" <olof@lixom.net>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mfd: cros_ec: Use the proper size when looking at the cros_ec_i2c result
Date: Thu, 3 Jul 2014 07:38:58 +0100 [thread overview]
Message-ID: <20140703063858.GD17665@lee--X1> (raw)
In-Reply-To: <CAD=FV=VRA-WLgxqQ37naFLcoBM3fBM8FWPcLv8X_wZ89wiV4KA@mail.gmail.com>
On Wed, 02 Jul 2014, Doug Anderson wrote:
> On Wed, Jul 2, 2014 at 12:23 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Fri, 27 Jun 2014, Doug Anderson wrote:
> >
> >> We know how many bytes the EC should be sending us (which is also the
> >> number of bytes transferred) and also how many bytes the EC actually
> >> wanted to send to us. When computing the checksum and copying back
> >> data let's make sure we take the lesser of the two of those. We'll
> >> also complain if the EC tried to send us too many bytes. The EC
> >> sending us too few bytes is legit for when we send the EC an invalid
> >> command.
> >>
> >> This is based on similar code in cros_ec_spi.
> >>
> >> Signed-off-by: Doug Anderson <dianders@chromium.org>
> >> ---
> >> drivers/mfd/cros_ec_i2c.c | 15 ++++++++++++---
> >> 1 file changed, 12 insertions(+), 3 deletions(-)
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Is this patch orthogonal i.e. can it be applied without the other two
> > patches?
>
> Yes. If patch 3/3 had worked out then it would have required patch #1
> for proper functioning and patch #2 (this patch) to avoid an ugly
> error message in the log. ...but patch #1 and this patch both can
> stand on their own and can be applied.
Very well, patch applied than.
Clause: There is a chance that this patch might not be seen in -next
for ~24-48hrs. If it's not there by 72hrs, feel free to poke.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-03 6:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 19:56 [PATCH 0/3] Add support for limited i2c tunnel for exynos5250-spring Doug Anderson
2014-06-27 19:56 ` [PATCH 1/3] regmap: cache: regcache_hw_init() should use regmap_bulk_read() Doug Anderson
2014-07-03 14:55 ` Mark Brown
2014-06-27 19:56 ` [PATCH 2/3] mfd: cros_ec: Use the proper size when looking at the cros_ec_i2c result Doug Anderson
2014-06-30 19:36 ` Simon Glass
2014-07-02 7:23 ` Lee Jones
2014-07-02 15:51 ` Doug Anderson
2014-07-03 6:38 ` Lee Jones [this message]
[not found] ` <1403898973-19571-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-06-27 19:56 ` [PATCH 3/3] i2c: cros_ec: Support a limited i2c tunnel for exynos5250-spring Doug Anderson
2014-06-27 19:56 ` Doug Anderson
2014-06-27 21:44 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703063858.GD17665@lee--X1 \
--to=lee.jones@linaro.org \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rspangler@chromium.org \
--cc=sameo@linux.intel.com \
--cc=sjg@chromium.org \
--cc=stephan@synkhronix.com \
--cc=vpalatin@chromium.org \
--cc=wfrichar@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.