From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 06/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device Date: Thu, 3 Jul 2014 08:29:43 +0100 Message-ID: <20140703072943.GD30534@lee--X1> References: <1403115247-8853-1-git-send-email-dianders@chromium.org> <1403115247-8853-7-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1403115247-8853-7-git-send-email-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Andrew Bresticker , swarren@wwwdotorg.org, olof@lixom.net, Sonny Rao , linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas , Bill Richardson , sjg@chromium.org, Wolfram Sang , broonie@kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On Wed, 18 Jun 2014, Doug Anderson wrote: > From: Bill Richardson >=20 > struct cros_ec_device has a superfluous "name" field. We can get all = the > debugging info we need from the existing ec_name and phys_name fields= , so > let's take out the extra field. >=20 > The printout also has sufficient info in it without explicitly adding > the transport. Before this change: > cros-ec-spi spi2.0: Chrome EC (SPI) >=20 > After this change: > cros-ec-spi spi2.0: Chrome EC device registered >=20 > Signed-off-by: Bill Richardson > Signed-off-by: Doug Anderson > Acked-by: Lee Jones > Reviewed-by: Simon Glass > --- > Changes in v2: > - Include example printouts before/after in commit message. Patch applied. Clause: There is a chance that this patch might not be seen in -next for ~24-48hrs. If it's not there by 72hrs, feel free to poke. > drivers/mfd/cros_ec.c | 2 +- > drivers/mfd/cros_ec_i2c.c | 1 - > drivers/mfd/cros_ec_spi.c | 1 - > include/linux/mfd/cros_ec.h | 2 -- > 4 files changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index 2e86c28..49ed8c3 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -140,7 +140,7 @@ int cros_ec_register(struct cros_ec_device *ec_de= v) > goto fail_mfd; > } > =20 > - dev_info(dev, "Chrome EC (%s)\n", ec_dev->name); > + dev_info(dev, "Chrome EC device registered\n"); > =20 > return 0; > =20 > diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c > index 37ed12f..5bb32f5 100644 > --- a/drivers/mfd/cros_ec_i2c.c > +++ b/drivers/mfd/cros_ec_i2c.c > @@ -132,7 +132,6 @@ static int cros_ec_i2c_probe(struct i2c_client *c= lient, > return -ENOMEM; > =20 > i2c_set_clientdata(client, ec_dev); > - ec_dev->name =3D "I2C"; > ec_dev->dev =3D dev; > ec_dev->priv =3D client; > ec_dev->irq =3D client->irq; > diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c > index 2d713fe..09ca789 100644 > --- a/drivers/mfd/cros_ec_spi.c > +++ b/drivers/mfd/cros_ec_spi.c > @@ -374,7 +374,6 @@ static int cros_ec_spi_probe(struct spi_device *s= pi) > cros_ec_spi_dt_probe(ec_spi, dev); > =20 > spi_set_drvdata(spi, ec_dev); > - ec_dev->name =3D "SPI"; > ec_dev->dev =3D dev; > ec_dev->priv =3D ec_spi; > ec_dev->irq =3D spi->irq; > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.= h > index f27c037..2b0c598 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -67,7 +67,6 @@ struct cros_ec_command { > * @command_recv: receive a response > * @command_sendrecv: send a command and receive a response > * > - * @name: Name of this EC interface > * @priv: Private data > * @irq: Interrupt to use > * @din: input buffer (for data from EC) > @@ -104,7 +103,6 @@ struct cros_ec_device { > void *in_buf, int in_len); > =20 > /* These are used to implement the platform-specific interface */ > - const char *name; > void *priv; > int irq; > uint8_t *din; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog