From: Christoph Hellwig <hch@infradead.org>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH V2] scsi_lib: removes ambiguous "Unhandled error code" messages.
Date: Thu, 3 Jul 2014 01:41:08 -0700 [thread overview]
Message-ID: <20140703084108.GA4296@infradead.org> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B402958B4C8CD@G9W0745.americas.hpqcorp.net>
On Wed, Jun 25, 2014 at 08:38:47PM +0000, Elliott, Robert (Server Storage) wrote:
> Since the ACTION_FAIL case always prints the sense key
> and additional sense code:
> perhaps the description string should be removed altogether?
> For the "Unhandled error code" (for which you are proposing
> removing the string) and the timeout case, the scsi_print_result
> call already prints hostbyte and driverbyte, which explain what
> happened in more detail:
I'm tempted to agree and just remove the description. Do you want to
send a patch for this?
next prev parent reply other threads:[~2014-07-03 8:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 8:10 [PATCH V2] scsi_lib: removes ambiguous "Unhandled error code" messages Maurizio Lombardi
2014-06-06 14:12 ` Christoph Hellwig
2014-06-25 11:06 ` Christoph Hellwig
2014-06-25 20:38 ` Elliott, Robert (Server Storage)
2014-07-03 8:41 ` Christoph Hellwig [this message]
2014-07-08 8:36 ` Maurizio Lombardi
2014-07-09 10:49 ` Hannes Reinecke
2014-06-25 17:41 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703084108.GA4296@infradead.org \
--to=hch@infradead.org \
--cc=Elliott@hp.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.