From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter Date: Thu, 3 Jul 2014 15:28:26 +0200 Message-ID: <20140703152826.103c9d6c@armhf> References: <20140702183841.7c964832@armhf> <20140702165628.GO20799@lunn.ch> <20140702195154.47d6f6b4@armhf> <20140702194252.GN410@sirena.org.uk> <20140703074959.7c489912@armhf> <20140703104432.GV410@sirena.org.uk> <20140703133406.2d3e3a1d@armhf> <20140703115924.GY410@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140703115924.GY410@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Brown Cc: Andrew Lunn , alsa-devel@alsa-project.org, Russell King - ARM Linux , devicetree@vger.kernel.org, lgirdwood@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gVGh1LCAzIEp1bCAyMDE0IDEyOjU5OjI0ICswMTAwCk1hcmsgQnJvd24gPGJyb29uaWVAa2Vy bmVsLm9yZz4gd3JvdGU6Cgo+ID4gPiBZb3VyIGJvYXJkIGhhcHBlbnMgdG8gb25seSBiZSBhYmxl IHRvIHByZXNlbnQgdGhlIHNhbWUgaW5wdXQgb24gYm90aCBJMlMKPiA+ID4gYW5kIFMvUERJRiBi dXQgdGhhdCBtaWdodCBub3QgYXBwbHkgdG8gb3RoZXIgYm9hcmRzLCB0aGV5IG1heSBiZSBhYmxl IHRvCj4gPiA+IHJvdXRlIGRpZmZlcmVudCBzaWduYWxzIHRvIGVhY2ggd2hpY2ggd291bGQgcHJl c2VudCBhIHByYWN0aWNhbCBwcm9ibGVtLiAgCj4gCj4gPiBJZiB0aGVyZSBhcmUgdHdvIGRpZmZl cmVudCBzdHJlYW1zcyBvbiBJMlMgYW5kIFMvUERJRiwgYW5kIGlmIHRoZSBhdWRpbwo+ID4gc3Vi c3lzdGVtIHdhbnRzIHRvIHJvdXRlIHRoZXNlIHN0cmVhbXMgdG8gdGhlIHNhbWUgY29ubmVjdG9y ICh3aWRnZXQKPiA+ICdoZG1pLW91dCcpLCB0aGVuLCBzb21ld2hlcmUsIHRoZXJlIHNob3VsZCBi ZSBhIHNvZnR3YXJlIG9yIGEgZGVzaWduCj4gPiBidWcuIE5vPyAgCj4gCj4gWWVzLCB3aGljaCBp cyB3aHkgdGhlIGRyaXZlciBzaG91bGRuJ3Qgc2lsZW50bHkgaWdub3JlIHRoZSBzaXR1YXRpb24u Cj4gCj4gPiBBbnl3YXksIHRoZSB0ZGE5OTh4IGNhbm5vdCBrbm93IGlmIHRoZSBkb3VibGUgcm91 dGUgaXMgd2FudGVkIG9yIG5vdC4gIAo+IAo+IEl0IGRvZXNuJ3QgbmVlZCB0byBrbm93LCBpdCBq dXN0IG5lZWRzIHRvIGlkZW50aWZ5IHNvbWV0aGluZyBpdCBjYW4ndAo+IHN1cHBvcnQgZWl0aGVy IGJ5IHByb3ZpZGluZyBhIHdheSB0byBwaWNrIHdoaWNoIGludGVyZmFjZSBpcyB1c2VkIG9yIGJ5 Cj4gcmVqZWN0aW5nIHRoZSBzZWNvbmQgaW50ZXJmYWNlLgoKT0suIG5vIHByb2JsZW0sIEkgY2Fu IGRvIHRoYXQ6IG9ubHkgdGhlIGZpcnN0IHN0cmVhbSBpcyBzd2l0Y2hlZCBhbmQKdGhlIHNlY29u ZCBpcyByZWplY3RlZC4KCkJ1dCwgdGhpcyBtZWFucyB0aGF0IHRoZXJlIHdpbGwgYmUgYSBsb3Qg b2YgZXJyb3JzIHdoZW4gRFBDTSB3aWxsIGJlCnVzZWQsIGJlY2F1c2UsIGluIG1vc3QgY2FzZXMg Zm9yIHRoZSBDdWJveCAoa2lya3dvb2QgYXVkaW8gKyB0ZGE5OTh4KSwKYm90aCB3YXlzIEkyUyBh bmQgUy9QRElGIHdpbGwgYmUgYWN0aXZhdGVkIGF0IHRoZSBzYW1lIHRpbWUgZm9yIGEKc2luZ2xl IHN0cmVhbSAoeW91IG1heSBub3RlIHRoYXQgdGhlIHJvdXRlcyBmcm9tIHRoZSBzZWNvbmQgaW5w dXQKY2Fubm90IGJlIGJsb2NrZWQgYnkgdGhlIENPREVDIGFmdGVyIGl0IHJlY2VpdmVkIHRoZSBm aXJzdCBpbnB1dCwKYmVjYXVzZSB0aGVzZSByb3V0ZXMgaGF2ZSBhbHJlYWR5IGJlZW4gY29tcHV0 ZWQpLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemggaGEgTGludXggYXRh diEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 3 Jul 2014 15:28:26 +0200 Subject: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter In-Reply-To: <20140703115924.GY410@sirena.org.uk> References: <20140702183841.7c964832@armhf> <20140702165628.GO20799@lunn.ch> <20140702195154.47d6f6b4@armhf> <20140702194252.GN410@sirena.org.uk> <20140703074959.7c489912@armhf> <20140703104432.GV410@sirena.org.uk> <20140703133406.2d3e3a1d@armhf> <20140703115924.GY410@sirena.org.uk> Message-ID: <20140703152826.103c9d6c@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 3 Jul 2014 12:59:24 +0100 Mark Brown wrote: > > > Your board happens to only be able to present the same input on both I2S > > > and S/PDIF but that might not apply to other boards, they may be able to > > > route different signals to each which would present a practical problem. > > > If there are two different streamss on I2S and S/PDIF, and if the audio > > subsystem wants to route these streams to the same connector (widget > > 'hdmi-out'), then, somewhere, there should be a software or a design > > bug. No? > > Yes, which is why the driver shouldn't silently ignore the situation. > > > Anyway, the tda998x cannot know if the double route is wanted or not. > > It doesn't need to know, it just needs to identify something it can't > support either by providing a way to pick which interface is used or by > rejecting the second interface. OK. no problem, I can do that: only the first stream is switched and the second is rejected. But, this means that there will be a lot of errors when DPCM will be used, because, in most cases for the Cubox (kirkwood audio + tda998x), both ways I2S and S/PDIF will be activated at the same time for a single stream (you may note that the routes from the second input cannot be blocked by the CODEC after it received the first input, because these routes have already been computed). -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757396AbaGCN0e (ORCPT ); Thu, 3 Jul 2014 09:26:34 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:43017 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbaGCN0d convert rfc822-to-8bit (ORCPT ); Thu, 3 Jul 2014 09:26:33 -0400 Date: Thu, 3 Jul 2014 15:28:26 +0200 From: Jean-Francois Moine To: Mark Brown Cc: Andrew Lunn , Russell King - ARM Linux , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Dave Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter Message-ID: <20140703152826.103c9d6c@armhf> In-Reply-To: <20140703115924.GY410@sirena.org.uk> References: <20140702183841.7c964832@armhf> <20140702165628.GO20799@lunn.ch> <20140702195154.47d6f6b4@armhf> <20140702194252.GN410@sirena.org.uk> <20140703074959.7c489912@armhf> <20140703104432.GV410@sirena.org.uk> <20140703133406.2d3e3a1d@armhf> <20140703115924.GY410@sirena.org.uk> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Jul 2014 12:59:24 +0100 Mark Brown wrote: > > > Your board happens to only be able to present the same input on both I2S > > > and S/PDIF but that might not apply to other boards, they may be able to > > > route different signals to each which would present a practical problem. > > > If there are two different streamss on I2S and S/PDIF, and if the audio > > subsystem wants to route these streams to the same connector (widget > > 'hdmi-out'), then, somewhere, there should be a software or a design > > bug. No? > > Yes, which is why the driver shouldn't silently ignore the situation. > > > Anyway, the tda998x cannot know if the double route is wanted or not. > > It doesn't need to know, it just needs to identify something it can't > support either by providing a way to pick which interface is used or by > rejecting the second interface. OK. no problem, I can do that: only the first stream is switched and the second is rejected. But, this means that there will be a lot of errors when DPCM will be used, because, in most cases for the Cubox (kirkwood audio + tda998x), both ways I2S and S/PDIF will be activated at the same time for a single stream (you may note that the routes from the second input cannot be blocked by the CODEC after it received the first input, because these routes have already been computed). -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/