From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter Date: Thu, 3 Jul 2014 18:26:00 +0200 Message-ID: <20140703182600.7a98c5b6@armhf> References: <20140702165628.GO20799@lunn.ch> <20140702195154.47d6f6b4@armhf> <20140702194252.GN410@sirena.org.uk> <20140703074959.7c489912@armhf> <20140703104432.GV410@sirena.org.uk> <20140703133406.2d3e3a1d@armhf> <20140703115924.GY410@sirena.org.uk> <20140703152826.103c9d6c@armhf> <20140703134346.GW32514@n2100.arm.linux.org.uk> <20140703172909.60caf2c7@armhf> <20140703154325.GY32514@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140703154325.GY32514@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: Andrew Lunn , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, lgirdwood@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gVGh1LCAzIEp1bCAyMDE0IDE2OjQzOjI1ICswMTAwClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51 eCA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cgo+IFdoYXQgeW91J3JlIGRvaW5nIGlu IGtpcmt3b29kLWkycyBpcyBwcm92aWRpbmcgdHdvIHBsYWluIERBSSBsaW5rcywKPiBhbmQgdGhl biBpbnNpc3RpbmcgdGhhdCBvbmx5IG9uZSBjYW4gYmUgYWN0aXZlIGFueSBhbnkgb25lIHRpbWUu Cj4gCj4gQSBEUENNIHNvbHV0aW9uIHByb3ZpZGVzIGF0IGxlYXN0IG9uZSBmcm9udGVuZCBEQUkg bGluayBhbmQgYXQgbGVhc3QKPiBvbmUgYmFja2VuZCBEQUkgbGluay4gIFlvdXIgY29kZSBkb2Vz IG5vdCBkbyB0aGlzLgoKWW91IGtub3cgd2h5IEkgZGlkIG5vdCBpbnNlcnQgdGhlIERQQ00gY29k ZSBpbiB0aGUga2lya3dvb2QgZHJpdmVyOiBpdApkb2VzIG5vdCB3b3JrLiBCdXQsIGFzIEkgdGVz dGVkIGl0IGVuZCAyMDEzLCBJIHN0aWxsIGhhdmUgdGhlIGNvZGUuCkRvIHlvdSB3YW50IEkgcHJv cG9zZSBhIHBhdGNoPwoKPiBXaGljaCBiaXQgb2YgIndlIG5lZWQgdG8gc3VwcG9ydCBib3RoIEky UyBhbmQgU1BESUYiIGluIG15IHByZXZpb3VzCj4gZW1haWxzIHdhcyBub3QgY2xlYXIuICBXaGlj aCBiaXQgb2YgIldlIHNob3VsZCBvbmx5IHN1cHBvcnQgU1BESUYKPiBvbiB0aGUgQ3Vib3giIHdh cyBub3QgY2xlYXI/Cj4gCj4gSSAqZnVsbHkqIGFja25vd2xlZGdlIHRoYXQgd2UgbmVlZCB0byBz dXBwb3J0IGJvdGgsIGJ1dCBJJ20gcHV0dGluZwo+IGEgX3N0cm9uZ18gcmVjb21tZW5kYXRpb24g dG8geW91IF93aXRoXyB0ZWNobmljYWwgcmVhc29ucyB3aHkgd2UKPiBzaG91bGQgX29ubHlfIHN1 cHBvcnQgU1BESUYgb24gdGhlIEN1Ym94LgoKU29ycnksIEkgc3RpbGwgZG9uJ3Qgc2VlIHdoeSBv bmx5IFMvUERJRiBzaG91bGQgYmUgc3VwcG9ydGVkIG9uIHRoZQpDdWJveC4gSSBoYXZlIGJvdGgs IGFuZCBib3RoIGFyZSB3b3JraW5nIG9uIEhETUkuIEkgaG9wZSBzb21lb25lIHdpbGwKdGVsbCBt ZSBpdCBhbHNvIHdvcmtzIG9uIFMvUERJRjogdGhlcmUgaXMgbm8gcmVhc29uIGl0IGNvdWxkIG5v dC4KCkkgZG9uJ3Qgc2VlIHlvdXIgdGVjaG5pY2FsIHJlYXNvbnM6IHlvdSBrbm93IHRoZSBjb25z dHJhaW50cyBvZiBlYWNoCnByb3RvY29sIEkyUyBhbmQgUy9QRElGLiBJZiB5b3UgZG9uJ3Qgd2Fu dCBJMlMsIGp1c3QgZG9uJ3QgZGVjbGFyZSBpdAppbiB0aGUgRFQgKHNlZSBteSBwcmV2aW91cyBt YWlsKS4gWW91IG1heSBhbHNvIG5vdGUgdGhhdCBJIGRpZCBub3QgcHV0CmFueSBjaGFuZ2UgcmVs YXRpdmUgdG8gdGhlIEN1Ym94IERUIGluIG15IHBhdGNoLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJ fAkgICAgICAqKiBCcmVpemggaGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVq Zi5mcmVlLmZyLwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 3 Jul 2014 18:26:00 +0200 Subject: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter In-Reply-To: <20140703154325.GY32514@n2100.arm.linux.org.uk> References: <20140702165628.GO20799@lunn.ch> <20140702195154.47d6f6b4@armhf> <20140702194252.GN410@sirena.org.uk> <20140703074959.7c489912@armhf> <20140703104432.GV410@sirena.org.uk> <20140703133406.2d3e3a1d@armhf> <20140703115924.GY410@sirena.org.uk> <20140703152826.103c9d6c@armhf> <20140703134346.GW32514@n2100.arm.linux.org.uk> <20140703172909.60caf2c7@armhf> <20140703154325.GY32514@n2100.arm.linux.org.uk> Message-ID: <20140703182600.7a98c5b6@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 3 Jul 2014 16:43:25 +0100 Russell King - ARM Linux wrote: > What you're doing in kirkwood-i2s is providing two plain DAI links, > and then insisting that only one can be active any any one time. > > A DPCM solution provides at least one frontend DAI link and at least > one backend DAI link. Your code does not do this. You know why I did not insert the DPCM code in the kirkwood driver: it does not work. But, as I tested it end 2013, I still have the code. Do you want I propose a patch? > Which bit of "we need to support both I2S and SPDIF" in my previous > emails was not clear. Which bit of "We should only support SPDIF > on the Cubox" was not clear? > > I *fully* acknowledge that we need to support both, but I'm putting > a _strong_ recommendation to you _with_ technical reasons why we > should _only_ support SPDIF on the Cubox. Sorry, I still don't see why only S/PDIF should be supported on the Cubox. I have both, and both are working on HDMI. I hope someone will tell me it also works on S/PDIF: there is no reason it could not. I don't see your technical reasons: you know the constraints of each protocol I2S and S/PDIF. If you don't want I2S, just don't declare it in the DT (see my previous mail). You may also note that I did not put any change relative to the Cubox DT in my patch. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759114AbaGCQYK (ORCPT ); Thu, 3 Jul 2014 12:24:10 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:8115 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757565AbaGCQYI convert rfc822-to-8bit (ORCPT ); Thu, 3 Jul 2014 12:24:08 -0400 Date: Thu, 3 Jul 2014 18:26:00 +0200 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Mark Brown , Andrew Lunn , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Dave Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter Message-ID: <20140703182600.7a98c5b6@armhf> In-Reply-To: <20140703154325.GY32514@n2100.arm.linux.org.uk> References: <20140702165628.GO20799@lunn.ch> <20140702195154.47d6f6b4@armhf> <20140702194252.GN410@sirena.org.uk> <20140703074959.7c489912@armhf> <20140703104432.GV410@sirena.org.uk> <20140703133406.2d3e3a1d@armhf> <20140703115924.GY410@sirena.org.uk> <20140703152826.103c9d6c@armhf> <20140703134346.GW32514@n2100.arm.linux.org.uk> <20140703172909.60caf2c7@armhf> <20140703154325.GY32514@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Jul 2014 16:43:25 +0100 Russell King - ARM Linux wrote: > What you're doing in kirkwood-i2s is providing two plain DAI links, > and then insisting that only one can be active any any one time. > > A DPCM solution provides at least one frontend DAI link and at least > one backend DAI link. Your code does not do this. You know why I did not insert the DPCM code in the kirkwood driver: it does not work. But, as I tested it end 2013, I still have the code. Do you want I propose a patch? > Which bit of "we need to support both I2S and SPDIF" in my previous > emails was not clear. Which bit of "We should only support SPDIF > on the Cubox" was not clear? > > I *fully* acknowledge that we need to support both, but I'm putting > a _strong_ recommendation to you _with_ technical reasons why we > should _only_ support SPDIF on the Cubox. Sorry, I still don't see why only S/PDIF should be supported on the Cubox. I have both, and both are working on HDMI. I hope someone will tell me it also works on S/PDIF: there is no reason it could not. I don't see your technical reasons: you know the constraints of each protocol I2S and S/PDIF. If you don't want I2S, just don't declare it in the DT (see my previous mail). You may also note that I did not put any change relative to the Cubox DT in my patch. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/