All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: sunxi: Fix multi bank interrupt support in gpio_to_irq
Date: Fri, 4 Jul 2014 09:22:43 +0200	[thread overview]
Message-ID: <20140704072243.GK31996@lukather> (raw)
In-Reply-To: <CAGb2v67ZNsq9J1Fs3uURJbDPvCvPUDm6rYXq=FfuZCAo1HtaRQ@mail.gmail.com>

On Fri, Jul 04, 2014 at 03:11:04PM +0800, Chen-Yu Tsai wrote:
> On Fri, Jul 4, 2014 at 3:03 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Tue, Jul 01, 2014 at 12:04:59AM +0800, Chen-Yu Tsai wrote:
> >> When mapping the interrupts, the gpio_to_irq function did not consider
> >> the bank number of the gpio pin in question, only the offset or the
> >> interrupt number in the bank. As a result, requests for interrupts in
> >> the later banks get mapped to the first bank.
> >>
> >> This issue was discovered while enabling mmc on the new sun8i platform.
> >> The tablet I have uses a pin/interrupt from the second bank to do mmc
> >> card detection. Tested on this very device with register inspection and
> >> actual mmc card insertion/removal.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >
> > Linus, could this be merged as a fix for 3.16?
> 
> Aren't your multi-bank external interrupt patches queued for 3.17?
> This patch applies over them.

Ah, yes, you're right.

Sorry for the noise :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140704/bc1b6b4d/attachment.sig>

  reply	other threads:[~2014-07-04  7:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 16:04 [PATCH] pinctrl: sunxi: Fix multi bank interrupt support in gpio_to_irq Chen-Yu Tsai
2014-07-04  7:03 ` Maxime Ripard
2014-07-04  7:11   ` Chen-Yu Tsai
2014-07-04  7:22     ` Maxime Ripard [this message]
2014-07-04 21:44 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140704072243.GK31996@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.