From: Paul Mackerras <paulus@samba.org>
To: Joel Stanley <joel@jms.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] powerpc/kvm: Remove redundant save of SIER AND MMCR2
Date: Fri, 4 Jul 2014 17:46:50 +1000 [thread overview]
Message-ID: <20140704074649.GA5852@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1404367956-19515-2-git-send-email-joel@jms.id.au>
On Thu, Jul 03, 2014 at 03:42:34PM +0930, Joel Stanley wrote:
> These two registers are already saved in the block above. Aside from
> being unnecessary, by the time we get down to the second save location
> r8 no longer contains MMCR2, so we are clobbering the saved value with
> PMC5.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Eek!
Acked-by: Paul Mackerras <paulus@samba.org>
next prev parent reply other threads:[~2014-07-04 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 6:12 [PATCH 0/3] POWER8 PMU bugfixes Joel Stanley
2014-07-03 6:12 ` [PATCH 1/3] powerpc/kvm: Remove redundant save of SIER AND MMCR2 Joel Stanley
2014-07-04 2:16 ` Michael Ellerman
2014-07-04 7:46 ` Paul Mackerras [this message]
2014-07-04 7:57 ` Alexander Graf
2014-07-04 7:57 ` Alexander Graf
2014-07-04 7:57 ` Alexander Graf
2014-07-03 6:12 ` [PATCH 2/3] powerpc/perf: Add PPMU_ARCH_207S define Joel Stanley
2014-07-04 2:34 ` Michael Ellerman
2014-07-03 6:12 ` [PATCH 3/3] powerpc/perf: Clear MMCR2 when enabling PMU Joel Stanley
2014-07-04 2:36 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140704074649.GA5852@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.