From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kirill Batuzov <batuzovk@ispras.ru>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-char: add chr_add_watch support in mux chardev
Date: Sun, 6 Jul 2014 08:42:51 +0300 [thread overview]
Message-ID: <20140706054251.GB5007@redhat.com> (raw)
In-Reply-To: <1404477795-1067-1-git-send-email-batuzovk@ispras.ru>
On Fri, Jul 04, 2014 at 04:43:15PM +0400, Kirill Batuzov wrote:
> Forward chr_add_watch call from mux chardev to underlying
> implementation.
>
> This should fix bug #1335444
>
> Signed-off-by: Kirill Batuzov <batuzovk@ispras.ru>
Applied for this once, but please note 2.1 patches
need to be tagged explicitly from now on.
> ---
> qemu-char.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 51917de..e1bd6f5 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -581,6 +581,12 @@ static Notifier muxes_realize_notify = {
> .notify = muxes_realize_done,
> };
>
> +static GSource *mux_chr_add_watch(CharDriverState *s, GIOCondition cond)
> +{
> + MuxDriver *d = s->opaque;
> + return d->drv->chr_add_watch(d->drv, cond);
> +}
> +
> static CharDriverState *qemu_chr_open_mux(CharDriverState *drv)
> {
> CharDriverState *chr;
> @@ -597,6 +603,9 @@ static CharDriverState *qemu_chr_open_mux(CharDriverState *drv)
> chr->chr_accept_input = mux_chr_accept_input;
> /* Frontend guest-open / -close notification is not support with muxes */
> chr->chr_set_fe_open = NULL;
> + if (drv->chr_add_watch) {
> + chr->chr_add_watch = mux_chr_add_watch;
> + }
> /* only default to opened state if we've realized the initial
> * set of muxes
> */
> --
> 1.7.10.4
prev parent reply other threads:[~2014-07-06 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 12:43 [Qemu-devel] [PATCH] qemu-char: add chr_add_watch support in mux chardev Kirill Batuzov
2014-07-04 13:23 ` Paolo Bonzini
2014-07-06 5:42 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140706054251.GB5007@redhat.com \
--to=mst@redhat.com \
--cc=batuzovk@ispras.ru \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.