All of lore.kernel.org
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: integrator: fix OF-related regression
Date: Sun, 6 Jul 2014 17:51:45 -0700	[thread overview]
Message-ID: <20140707005145.GH8469@quad.lixom.net> (raw)
In-Reply-To: <CACRpkdbr05q4iNG00eX1e1ZWKHEmGZ5exGHR9WRPuyFzrs6Tkg@mail.gmail.com>

On Mon, Jun 30, 2014 at 06:52:58PM +0200, Linus Walleij wrote:
> On Thu, Jun 26, 2014 at 9:39 PM, Rabin Vincent <rabin@rab.in> wrote:
> 
> > earlyprintk doesn't work on Integrator hardware?
> 
> It does, but loading the kernel is done over serial line 115200 bps
> so iterative tests take "some time" :-)
> 
> > It does on QEMU's
> > integratorcp so it's trivial to debug there.
> 
> Yeah I should be using QEMU for things like this ... poke self.
> 
> > The problem is that integrator_init_sysfs() adds a device attribute
> > called "fpga" to the soc0 bus, and the soc0 bus device is also used as
> > the root of the device tree, and the device tree has a node called "fpga".
> (...)
> > 07e461cd7e73a84f0e3757932b93cc80976fd749 removed the .0 from the fpga node's
> > directory, leading to that node (and its subnodes) failing to register due to a
> > filename conflict with the fpga attribute's file:
> 
> Aha! Thanks for root-causing this Rabin. Awesome.
> 
> > After Linus' patch, the root is no longer soc0 so the fpga node's directory
> > becomes /devices/fpga while the attribute file remains at /devices/soc0/fpga.
> 
> It appears the patch is doing the right thing, though I had very vague
> ideas as to why.

Ok, sounds like this is good to go. I'll apply it to the fixes branch, we can
fairly easily take it out right now if it needs to bake more so please speak up
quickly if that is the case.


-Olof

  reply	other threads:[~2014-07-07  0:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 12:08 [PATCH] ARM: integrator: fix OF-related regression Linus Walleij
2014-06-25 13:06 ` Rob Herring
2014-06-26 12:15   ` Linus Walleij
2014-06-26 19:39     ` Rabin Vincent
2014-06-26 21:31       ` Rob Herring
2014-06-27 12:14         ` Grant Likely
2014-06-30 16:52       ` Linus Walleij
2014-07-07  0:51         ` Olof Johansson [this message]
2014-07-07  0:53           ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140707005145.GH8469@quad.lixom.net \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.