From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X48Ak-0003Dq-58
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:37:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X48Ac-0008Qb-EA
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:37:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35276)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X48Ac-0008P3-1E
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:37:22 -0400
Date: Mon, 7 Jul 2014 15:39:17 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140707123917.GB21346@redhat.com>
References: <cover.1404730357.git.hutao@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1404730357.git.hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH V3 for 2.1 0/2] bug fixs for memory backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>

On Mon, Jul 07, 2014 at 06:55:26PM +0800, Hu Tao wrote:
> This series includes two patches to fix bugs of memory backend. See each
> patch for the bugs and how to reproduce them.
> 
> changes to v2:
> 
> - introduce memory_region_init_ram_may_fail and
>   memory_region_init_ram_ptr_may_fail
> 
> - address comments by MST
> 
> - missing the functions renaming. will send later.
> 
> Hu Tao (2):
>   memory: add memory_region_init_ram_may_fail() and    
>     memory_region_init_ram_ptr_may_fail()
>   exec: improve error handling and reporting in file_ram_alloc() and
>     gethugepagesize()

I'm not merging this for 2.1, sorry.
There's a simple workaround, we can fix this in 2.2.


>  backends/hostmem-ram.c  |  4 ++--
>  exec.c                  | 51 +++++++++++++++++++++++++++--------------
>  hw/block/pflash_cfi01.c |  5 +++-
>  hw/block/pflash_cfi02.c |  5 +++-
>  include/exec/memory.h   | 40 +++++++++++++++++++++++++++++++-
>  include/exec/ram_addr.h |  4 ++--
>  memory.c                | 61 +++++++++++++++++++++++++++++++++++++++----------
>  7 files changed, 134 insertions(+), 36 deletions(-)
> 
> -- 
> 1.9.3