From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <will.deacon@arm.com>) id 1X48S8-00067b-93
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:55:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <will.deacon@arm.com>) id 1X48S2-0006FQ-4U
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:55:28 -0400
Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:34596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <will.deacon@arm.com>) id 1X48S1-0006Ex-8W
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:55:22 -0400
Date: Mon, 7 Jul 2014 13:49:56 +0100
From: Will Deacon <will.deacon@arm.com>
Message-ID: <20140707124955.GH3676@arm.com>
References: <1404736043-22900-1-git-send-email-eric.auger@linaro.org>
	<1404736043-22900-9-git-send-email-eric.auger@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1404736043-22900-9-git-send-email-eric.auger@linaro.org>
Subject: Re: [Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to
	VFIO DMA mappings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Auger <eric.auger@linaro.org>
Cc: "agraf@suse.de" <agraf@suse.de>, "kim.phillips@freescale.com" <kim.phillips@freescale.com>, "eric.auger@st.com" <eric.auger@st.com>, "peter.maydell@linaro.org" <peter.maydell@linaro.org>, "patches@linaro.org" <patches@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "a.rigo@virtualopensystems.com" <a.rigo@virtualopensystems.com>, "Bharat.Bhushan@freescale.com" <Bharat.Bhushan@freescale.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "stuart.yoder@freescale.com" <stuart.yoder@freescale.com>, "a.motakis@virtualopensystems.com" <a.motakis@virtualopensystems.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, "christoffer.dall@linaro.org" <christoffer.dall@linaro.org>

On Mon, Jul 07, 2014 at 01:27:18PM +0100, Eric Auger wrote:
> From: Alvise Rigo <a.rigo@virtualopensystems.com>
> 
> The flag is mandatory for the ARM SMMU so we always add it if the MMIO
> handles it.

I though the logic of this flag was changing (so that you request an NX
mapping instead), so I'd hold off on this change until the kernel has
decided what it's doing.

Also, the ARM SMMU doesn't mandate any flags, you probably need this as
a result of using a PL330, which is an odd case of a DMA master that
spits out EXEC transactions (instruction fetch).

Will