From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: component: add support for component match array
Date: Mon, 07 Jul 2014 14:25:09 +0000 [thread overview]
Message-ID: <20140707142509.GA16408@mwanda> (raw)
Hello Russell King,
This is a semi-automatic email about new static checker warnings.
The patch 6955b58254c2: "component: add support for component match
array" from Apr 19, 2014, leads to the following Smatch complaint:
drivers/base/component.c:297 component_master_add_with_match()
error: we previously assumed 'match' could be null (see line 293)
drivers/base/component.c
292
293 if (ops->add_components && match)
^^^^^
Patch adds new check.
294 return -EINVAL;
295
296 /* Reallocate the match array for its true size */
297 match = component_match_realloc(dev, match, match->num);
^^^^^^^^^^
Patch adds unchecked dereference.
298 if (IS_ERR(match))
299 return PTR_ERR(match);
regards,
dan carpenter
reply other threads:[~2014-07-07 14:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707142509.GA16408@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.