From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerald Schaefer Subject: Re: [PATCH v10 5/7] s390: add pmd_[dirty|mkclean] for THP Date: Mon, 7 Jul 2014 17:31:43 +0200 Message-ID: <20140707173143.271bbd52@thinkpad> References: <1404694438-10272-1-git-send-email-minchan@kernel.org> <1404694438-10272-6-git-send-email-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404694438-10272-6-git-send-email-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Minchan Kim Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Martin Schwidefsky , Heiko Carstens , Dominik Dingel , Christian Borntraeger , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Mon, 7 Jul 2014 09:53:56 +0900 Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page but for s390 pmds only referenced bit is available > because there is no free bit left in the pmd entry for the > software dirty bit so this patch adds dumb pmd_dirty which > returns always true by suggesting by Martin. > > They finally find a solution in future. > http://marc.info/?l=linux-api&m=140440328820808&w=2 > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Gerald Schaefer > Cc: Dominik Dingel > Cc: Christian Borntraeger > Cc: linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Minchan Kim > --- > arch/s390/include/asm/pgtable.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Acked-by: Gerald Schaefer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by kanga.kvack.org (Postfix) with ESMTP id B705B6B003D for ; Mon, 7 Jul 2014 11:31:53 -0400 (EDT) Received: by mail-wi0-f173.google.com with SMTP id cc10so16063570wib.6 for ; Mon, 07 Jul 2014 08:31:50 -0700 (PDT) Received: from e06smtp16.uk.ibm.com (e06smtp16.uk.ibm.com. [195.75.94.112]) by mx.google.com with ESMTPS id x16si41774024wiv.50.2014.07.07.08.31.49 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 07 Jul 2014 08:31:49 -0700 (PDT) Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Jul 2014 16:31:49 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9A5C517D805A for ; Mon, 7 Jul 2014 16:33:19 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s67FVkmg30867524 for ; Mon, 7 Jul 2014 15:31:46 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s67FVifE018634 for ; Mon, 7 Jul 2014 09:31:46 -0600 Date: Mon, 7 Jul 2014 17:31:43 +0200 From: Gerald Schaefer Subject: Re: [PATCH v10 5/7] s390: add pmd_[dirty|mkclean] for THP Message-ID: <20140707173143.271bbd52@thinkpad> In-Reply-To: <1404694438-10272-6-git-send-email-minchan@kernel.org> References: <1404694438-10272-1-git-send-email-minchan@kernel.org> <1404694438-10272-6-git-send-email-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Martin Schwidefsky , Heiko Carstens , Dominik Dingel , Christian Borntraeger , linux-s390@vger.kernel.org On Mon, 7 Jul 2014 09:53:56 +0900 Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page but for s390 pmds only referenced bit is available > because there is no free bit left in the pmd entry for the > software dirty bit so this patch adds dumb pmd_dirty which > returns always true by suggesting by Martin. > > They finally find a solution in future. > http://marc.info/?l=linux-api&m=140440328820808&w=2 > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Gerald Schaefer > Cc: Dominik Dingel > Cc: Christian Borntraeger > Cc: linux-s390@vger.kernel.org > Signed-off-by: Minchan Kim > --- > arch/s390/include/asm/pgtable.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Acked-by: Gerald Schaefer -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbaGGPby (ORCPT ); Mon, 7 Jul 2014 11:31:54 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:33835 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbaGGPbw (ORCPT ); Mon, 7 Jul 2014 11:31:52 -0400 Date: Mon, 7 Jul 2014 17:31:43 +0200 From: Gerald Schaefer To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Martin Schwidefsky , Heiko Carstens , Dominik Dingel , Christian Borntraeger , linux-s390@vger.kernel.org Subject: Re: [PATCH v10 5/7] s390: add pmd_[dirty|mkclean] for THP Message-ID: <20140707173143.271bbd52@thinkpad> In-Reply-To: <1404694438-10272-6-git-send-email-minchan@kernel.org> References: <1404694438-10272-1-git-send-email-minchan@kernel.org> <1404694438-10272-6-git-send-email-minchan@kernel.org> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14070715-4966-0000-0000-000000A3219E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Jul 2014 09:53:56 +0900 Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page but for s390 pmds only referenced bit is available > because there is no free bit left in the pmd entry for the > software dirty bit so this patch adds dumb pmd_dirty which > returns always true by suggesting by Martin. > > They finally find a solution in future. > http://marc.info/?l=linux-api&m=140440328820808&w=2 > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Gerald Schaefer > Cc: Dominik Dingel > Cc: Christian Borntraeger > Cc: linux-s390@vger.kernel.org > Signed-off-by: Minchan Kim > --- > arch/s390/include/asm/pgtable.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Acked-by: Gerald Schaefer