From: "J. Bruce Fields" <bfields@fieldses.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: Fix bad reserving space for encoding rdattr_error
Date: Mon, 7 Jul 2014 14:15:56 -0400 [thread overview]
Message-ID: <20140707181556.GC8630@fieldses.org> (raw)
In-Reply-To: <53B8C3D3.7080201@gmail.com>
On Sun, Jul 06, 2014 at 11:34:43AM +0800, Kinglong Mee wrote:
> Introduced by commit 561f0ed498 (nfsd4: allow large readdirs).
Whoops, thanks. Queueing up for 3.16.--b.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 3540462..5a1d088 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -2646,7 +2646,7 @@ nfsd4_encode_rdattr_error(struct xdr_stream *xdr, __be32 nfserr)
> {
> __be32 *p;
>
> - p = xdr_reserve_space(xdr, 6);
> + p = xdr_reserve_space(xdr, 20);
> if (!p)
> return NULL;
> *p++ = htonl(2);
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-07-07 18:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 3:34 [PATCH] nfsd: Fix bad reserving space for encoding rdattr_error Kinglong Mee
2014-07-07 18:15 ` J. Bruce Fields [this message]
2014-07-10 10:54 ` Christoph Hellwig
2014-07-11 20:11 ` J. Bruce Fields
2014-07-14 9:59 ` Christoph Hellwig
2014-07-16 22:06 ` J. Bruce Fields
2014-07-17 13:18 ` Kinglong Mee
2014-07-18 11:55 ` [PATCH] NFSD: Convert magic number to sizeof() for encode and decode Kinglong Mee
2014-08-12 20:40 ` J. Bruce Fields
2014-08-14 12:32 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707181556.GC8630@fieldses.org \
--to=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.