From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 8 Jul 2014 10:15:14 +0100 Subject: [PATCH resend] arm64: dmi: Add SMBIOS/DMI support In-Reply-To: References: <1404297277-28295-1-git-send-email-ard.biesheuvel@linaro.org> Message-ID: <20140708091513.GC8235@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 08, 2014 at 09:55:53AM +0100, Ard Biesheuvel wrote: > On 2 July 2014 12:34, Ard Biesheuvel wrote: > > From: Yi Li > > > > SMbios is important for server hardware vendors. It implements a spec for > > providing descriptive information about the platform. Things like serial > > numbers, physical layout of the ports, build configuration data, and the like. > > > > This has been tested by dmidecode and lshw tools. > > > > Signed-off-by: Yi Li > > [ardb: whitespace, commit log tweaks] > > Signed-off-by: Ard Biesheuvel > > --- > > > > Resending on behalf of Yi. > > Please consider for 3.17. > > > > Ping? Not sure what this does, but I can review it on a superficial level :) > > diff --git a/arch/arm64/include/asm/dmi.h b/arch/arm64/include/asm/dmi.h > > new file mode 100644 > > index 000000000000..b8758f46fb42 > > --- /dev/null > > +++ b/arch/arm64/include/asm/dmi.h > > @@ -0,0 +1,28 @@ > > +/* > > + * arch/arm64/include/asm/dmi.h > > + * > > + * Copyright (C) 2013 Linaro Limited. > > + * Written by: Yi Li (yi.li at linaro.org) > > + * > > + * based on arch/ia64/include/asm/dmi.h > > + * > > + * This file is subject to the terms and conditions of the GNU General Public > > + * License. See the file "COPYING" in the main directory of this archive > > + * for more details. > > + */ > > + > > + > > +#ifndef _ASM_DMI_H > > +#define _ASM_DMI_H 1 You don't need the 1 here (copied from ia64?). Also, please try to follow the existing style for arm64 and use __ASM_DMI_H. > > +#include > > +#include > > + > > +/* Use efi mappings for DMI */ > > +#define dmi_early_remap(x, l) efi_lookup_mapped_addr(x) Throwing away the length doesn't feel right, especially since the efi map *does* have a size field. > > +#define dmi_early_unmap(x, l) > > +#define dmi_remap(x, l) efi_lookup_mapped_addr(x) How do we guarantee that we don't call these after efi_free_boot_services? (it would be good to enforce that somehow). > > +#define dmi_unmap(x) > > +#define dmi_alloc(l) kzalloc(l, GFP_ATOMIC) Why does this have to be atomic? Will