From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: cxgb4 : Add DCBx support codebase and dcbnl_ops
Date: Tue, 08 Jul 2014 12:52:35 +0000 [thread overview]
Message-ID: <20140708125235.GA9963@mwanda> (raw)
Hello Anish Bhatt,
The patch 76bcb31efc06: "cxgb4 : Add DCBx support codebase and
dcbnl_ops" from Jun 19, 2014, leads to the following static checker
warning:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:679 cxgb4_setapp()
warn: signedness bug returning '(-22)'
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
669 static u8 cxgb4_setapp(struct net_device *dev, u8 app_idtype, u16 app_id,
670 u8 app_prio)
671 {
672 struct fw_port_cmd pcmd;
673 struct port_info *pi = netdev2pinfo(dev);
674 struct adapter *adap = pi->adapter;
675 int i, err;
676
677
678 if (pi->dcb.state != CXGB4_DCB_STATE_FW_ALLSYNCED)
679 return -EINVAL;
^^^^^^^^^^^^^^
See also:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:683 cxgb4_setapp() warn: signedness bug returning '(-67)'
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:687 cxgb4_setapp() warn: signedness bug returning '(-22)'
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:713 cxgb4_setapp() warn: signedness bug returning '(-16)'
regards,
dan carpenter
reply other threads:[~2014-07-08 12:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708125235.GA9963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.