From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] exynos: Put a stop to the userptr heresy. Date: Tue, 8 Jul 2014 15:37:15 +0200 Message-ID: <20140708133715.GD17271@phenom.ffwll.local> References: <1404164773-14759-1-git-send-email-j.glisse@gmail.com> <53B2777D.4050204@samsung.com> <20140701150317.GA2292@gmail.com> <20140702152517.GA2507@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 733B36E159 for ; Tue, 8 Jul 2014 06:37:05 -0700 (PDT) Received: by mail-wg0-f50.google.com with SMTP id x13so4849806wgg.21 for ; Tue, 08 Jul 2014 06:37:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140702152517.GA2507@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jerome Glisse , Dave Airlie Cc: kyungmin.park@samsung.com, Jerome Glisse , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Jul 02, 2014 at 11:25:19AM -0400, Jerome Glisse wrote: > Anyway as this is upstream i guess you can keep it. This is just an horrible > API that allow to circumvant any limit set by memcg for page locking and all. > But anyway GPU driver never played in the same ballpark as other driver. I agree that exynos userptr as-is should be removed since as opposed to the i915 implementation it doesn't play nice with the core mm and allos unpriviledged userspace to exceed all mlock limits. I've taken considerable amounts of internal heat for rejecting i915 userptr until the mmu notifier stuff was implemented and so really want exynos to fix this up asap. Dave? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch