All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alasdair Kergon <agk@redhat.com>,
	linux-raid@vger.kernel.org, dm-devel@redhat.com,
	kernel-janitors@vger.kernel.org
Subject: Re: dm: fix an error code in local_init()
Date: Tue, 8 Jul 2014 12:21:28 -0400	[thread overview]
Message-ID: <20140708162127.GA23439@redhat.com> (raw)
In-Reply-To: <20140708105536.GC19737@mwanda>

On Tue, Jul 08 2014 at  6:55am -0400,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> We return success if we can't allocate a work queue but we should return
> -ENOMEM.  The code was a bit messy so that's why this small bug was
> introduced and I have cleaned that as well.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan!  I folded your fix into the commit that introduced this bug
because that commit was marked for stable and will be sent to Linus
shortly.  See the new rebased commit here:

https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=58f3fce6ee8c37c1c18f36439102d5cccc5363c8

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alasdair Kergon <agk@redhat.com>,
	linux-raid@vger.kernel.org, dm-devel@redhat.com,
	kernel-janitors@vger.kernel.org
Subject: Re: dm: fix an error code in local_init()
Date: Tue, 08 Jul 2014 16:21:28 +0000	[thread overview]
Message-ID: <20140708162127.GA23439@redhat.com> (raw)
In-Reply-To: <20140708105536.GC19737@mwanda>

On Tue, Jul 08 2014 at  6:55am -0400,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> We return success if we can't allocate a work queue but we should return
> -ENOMEM.  The code was a bit messy so that's why this small bug was
> introduced and I have cleaned that as well.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan!  I folded your fix into the commit that introduced this bug
because that commit was marked for stable and will be sent to Linus
shortly.  See the new rebased commit here:

https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&idXf3fce6ee8c37c1c18f36439102d5cccc5363c8

  reply	other threads:[~2014-07-08 16:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 10:55 [patch] dm: fix an error code in local_init() Dan Carpenter
2014-07-08 10:55 ` Dan Carpenter
2014-07-08 16:21 ` Mike Snitzer [this message]
2014-07-08 16:21   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708162127.GA23439@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dm-devel@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.