From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v11 6/7] ARM: add pmd_[dirty|mkclean] for THP Date: Wed, 9 Jul 2014 14:38:37 +0900 Message-ID: <20140709053837.GC9824@bbox> References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-7-git-send-email-minchan@kernel.org> <20140708113737.GA2958@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20140708113737.GA2958@linaro.org> Sender: owner-linux-mm@kvack.org To: Steve Capper Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Catalin Marinas , Will Deacon , Russell King , linux-arm-kernel@lists.infradead.org List-Id: linux-api@vger.kernel.org Hello Steve, On Tue, Jul 08, 2014 at 12:37:38PM +0100, Steve Capper wrote: > On Tue, Jul 08, 2014 at 03:03:43PM +0900, Minchan Kim wrote: > > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > > overwrite of the contents since MADV_FREE syscall is called for > > THP page. > >=20 > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > > support. > >=20 > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Steve Capper > > Cc: Russell King > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Minchan Kim > > --- > > arch/arm/include/asm/pgtable-3level.h | 3 +++ > > arch/arm64/include/asm/pgtable.h | 2 ++ > > 2 files changed, 5 insertions(+) >=20 > Hi Minchan, > arch/arm and arch/arm64 are handled separately. > Could you please split this patch into arm and arm64 versions? >=20 Sure. >=20 > >=20 > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include= /asm/pgtable-3level.h > > index 85c60adc8b60..3a7bb8dc7d05 100644 > > --- a/arch/arm/include/asm/pgtable-3level.h > > +++ b/arch/arm/include/asm/pgtable-3level.h > > @@ -220,6 +220,8 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsig= ned long addr) > > #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) > > #endif > > =20 > > +#define pmd_dirty (pmd_val(pmd) & PMD_SECT_DIRTY) >=20 > This macro is missing the parameter definition, and will generate a > compile errror when CONFIG_ARM_LPAE=3Dy >=20 > For 32-bit ARM with CONFIG_ARM_LPAE=3Dn, we don't have THP support and = I noticed > some compiler errors in mm/madvise.c: >=20 > CC mm/madvise.o > mm/madvise.c: In function =E2=80=98madvise_free_pte_range=E2=80=99: > mm/madvise.c:279:3: error: implicit declaration of function =E2=80=98pm= dp_get_and_clear=E2=80=99 [-Werror=3Dimplicit-function-declaration] > orig_pmd =3D pmdp_get_and_clear(mm, addr, pmd); > ^ > mm/madvise.c:285:3: error: implicit declaration of function =E2=80=98pm= d_mkold=E2=80=99 [-Werror=3Dimplicit-function-declaration] > orig_pmd =3D pmd_mkold(orig_pmd); > ^ > mm/madvise.c:286:3: error: implicit declaration of function =E2=80=98pm= d_mkclean=E2=80=99 [-Werror=3Dimplicit-function-declaration] > orig_pmd =3D pmd_mkclean(orig_pmd); > ^ > mm/madvise.c:288:3: error: implicit declaration of function =E2=80=98se= t_pmd_at=E2=80=99 [-Werror=3Dimplicit-function-declaration] > set_pmd_at(mm, addr, pmd, orig_pmd); > ^ > cc1: some warnings being treated as errors > make[1]: *** [mm/madvise.o] Error 1 >=20 Oops, will fix. Thanks for the review! >=20 > Cheers, > --=20 > Steve=20 >=20 > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org --=20 Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: minchan@kernel.org (Minchan Kim) Date: Wed, 9 Jul 2014 14:38:37 +0900 Subject: [PATCH v11 6/7] ARM: add pmd_[dirty|mkclean] for THP In-Reply-To: <20140708113737.GA2958@linaro.org> References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-7-git-send-email-minchan@kernel.org> <20140708113737.GA2958@linaro.org> Message-ID: <20140709053837.GC9824@bbox> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Steve, On Tue, Jul 08, 2014 at 12:37:38PM +0100, Steve Capper wrote: > On Tue, Jul 08, 2014 at 03:03:43PM +0900, Minchan Kim wrote: > > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > > overwrite of the contents since MADV_FREE syscall is called for > > THP page. > > > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > > support. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Steve Capper > > Cc: Russell King > > Cc: linux-arm-kernel at lists.infradead.org > > Signed-off-by: Minchan Kim > > --- > > arch/arm/include/asm/pgtable-3level.h | 3 +++ > > arch/arm64/include/asm/pgtable.h | 2 ++ > > 2 files changed, 5 insertions(+) > > Hi Minchan, > arch/arm and arch/arm64 are handled separately. > Could you please split this patch into arm and arm64 versions? > Sure. > > > > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > > index 85c60adc8b60..3a7bb8dc7d05 100644 > > --- a/arch/arm/include/asm/pgtable-3level.h > > +++ b/arch/arm/include/asm/pgtable-3level.h > > @@ -220,6 +220,8 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) > > #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) > > #endif > > > > +#define pmd_dirty (pmd_val(pmd) & PMD_SECT_DIRTY) > > This macro is missing the parameter definition, and will generate a > compile errror when CONFIG_ARM_LPAE=y > > For 32-bit ARM with CONFIG_ARM_LPAE=n, we don't have THP support and I noticed > some compiler errors in mm/madvise.c: > > CC mm/madvise.o > mm/madvise.c: In function ?madvise_free_pte_range?: > mm/madvise.c:279:3: error: implicit declaration of function ?pmdp_get_and_clear? [-Werror=implicit-function-declaration] > orig_pmd = pmdp_get_and_clear(mm, addr, pmd); > ^ > mm/madvise.c:285:3: error: implicit declaration of function ?pmd_mkold? [-Werror=implicit-function-declaration] > orig_pmd = pmd_mkold(orig_pmd); > ^ > mm/madvise.c:286:3: error: implicit declaration of function ?pmd_mkclean? [-Werror=implicit-function-declaration] > orig_pmd = pmd_mkclean(orig_pmd); > ^ > mm/madvise.c:288:3: error: implicit declaration of function ?set_pmd_at? [-Werror=implicit-function-declaration] > set_pmd_at(mm, addr, pmd, orig_pmd); > ^ > cc1: some warnings being treated as errors > make[1]: *** [mm/madvise.o] Error 1 > Oops, will fix. Thanks for the review! > > Cheers, > -- > Steve > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo at kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email at kvack.org -- Kind regards, Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by kanga.kvack.org (Postfix) with ESMTP id 05BBA6B0031 for ; Wed, 9 Jul 2014 01:38:34 -0400 (EDT) Received: by mail-pd0-f169.google.com with SMTP id ft15so1615574pdb.28 for ; Tue, 08 Jul 2014 22:38:34 -0700 (PDT) Received: from lgeamrelo04.lge.com (lgeamrelo04.lge.com. [156.147.1.127]) by mx.google.com with ESMTP id fy14si6916108pdb.378.2014.07.08.22.38.32 for ; Tue, 08 Jul 2014 22:38:33 -0700 (PDT) Date: Wed, 9 Jul 2014 14:38:37 +0900 From: Minchan Kim Subject: Re: [PATCH v11 6/7] ARM: add pmd_[dirty|mkclean] for THP Message-ID: <20140709053837.GC9824@bbox> References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-7-git-send-email-minchan@kernel.org> <20140708113737.GA2958@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140708113737.GA2958@linaro.org> Sender: owner-linux-mm@kvack.org List-ID: To: Steve Capper Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Catalin Marinas , Will Deacon , Russell King , linux-arm-kernel@lists.infradead.org Hello Steve, On Tue, Jul 08, 2014 at 12:37:38PM +0100, Steve Capper wrote: > On Tue, Jul 08, 2014 at 03:03:43PM +0900, Minchan Kim wrote: > > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > > overwrite of the contents since MADV_FREE syscall is called for > > THP page. > > > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > > support. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Steve Capper > > Cc: Russell King > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Minchan Kim > > --- > > arch/arm/include/asm/pgtable-3level.h | 3 +++ > > arch/arm64/include/asm/pgtable.h | 2 ++ > > 2 files changed, 5 insertions(+) > > Hi Minchan, > arch/arm and arch/arm64 are handled separately. > Could you please split this patch into arm and arm64 versions? > Sure. > > > > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > > index 85c60adc8b60..3a7bb8dc7d05 100644 > > --- a/arch/arm/include/asm/pgtable-3level.h > > +++ b/arch/arm/include/asm/pgtable-3level.h > > @@ -220,6 +220,8 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) > > #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) > > #endif > > > > +#define pmd_dirty (pmd_val(pmd) & PMD_SECT_DIRTY) > > This macro is missing the parameter definition, and will generate a > compile errror when CONFIG_ARM_LPAE=y > > For 32-bit ARM with CONFIG_ARM_LPAE=n, we don't have THP support and I noticed > some compiler errors in mm/madvise.c: > > CC mm/madvise.o > mm/madvise.c: In function a??madvise_free_pte_rangea??: > mm/madvise.c:279:3: error: implicit declaration of function a??pmdp_get_and_cleara?? [-Werror=implicit-function-declaration] > orig_pmd = pmdp_get_and_clear(mm, addr, pmd); > ^ > mm/madvise.c:285:3: error: implicit declaration of function a??pmd_mkolda?? [-Werror=implicit-function-declaration] > orig_pmd = pmd_mkold(orig_pmd); > ^ > mm/madvise.c:286:3: error: implicit declaration of function a??pmd_mkcleana?? [-Werror=implicit-function-declaration] > orig_pmd = pmd_mkclean(orig_pmd); > ^ > mm/madvise.c:288:3: error: implicit declaration of function a??set_pmd_ata?? [-Werror=implicit-function-declaration] > set_pmd_at(mm, addr, pmd, orig_pmd); > ^ > cc1: some warnings being treated as errors > make[1]: *** [mm/madvise.o] Error 1 > Oops, will fix. Thanks for the review! > > Cheers, > -- > Steve > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbaGIFif (ORCPT ); Wed, 9 Jul 2014 01:38:35 -0400 Received: from lgeamrelo04.lge.com ([156.147.1.127]:47936 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbaGIFid (ORCPT ); Wed, 9 Jul 2014 01:38:33 -0400 X-Original-SENDERIP: 10.177.220.169 X-Original-MAILFROM: minchan@kernel.org Date: Wed, 9 Jul 2014 14:38:37 +0900 From: Minchan Kim To: Steve Capper Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Catalin Marinas , Will Deacon , Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 6/7] ARM: add pmd_[dirty|mkclean] for THP Message-ID: <20140709053837.GC9824@bbox> References: <1404799424-1120-1-git-send-email-minchan@kernel.org> <1404799424-1120-7-git-send-email-minchan@kernel.org> <20140708113737.GA2958@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140708113737.GA2958@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Steve, On Tue, Jul 08, 2014 at 12:37:38PM +0100, Steve Capper wrote: > On Tue, Jul 08, 2014 at 03:03:43PM +0900, Minchan Kim wrote: > > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > > overwrite of the contents since MADV_FREE syscall is called for > > THP page. > > > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > > support. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Steve Capper > > Cc: Russell King > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Minchan Kim > > --- > > arch/arm/include/asm/pgtable-3level.h | 3 +++ > > arch/arm64/include/asm/pgtable.h | 2 ++ > > 2 files changed, 5 insertions(+) > > Hi Minchan, > arch/arm and arch/arm64 are handled separately. > Could you please split this patch into arm and arm64 versions? > Sure. > > > > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > > index 85c60adc8b60..3a7bb8dc7d05 100644 > > --- a/arch/arm/include/asm/pgtable-3level.h > > +++ b/arch/arm/include/asm/pgtable-3level.h > > @@ -220,6 +220,8 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) > > #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) > > #endif > > > > +#define pmd_dirty (pmd_val(pmd) & PMD_SECT_DIRTY) > > This macro is missing the parameter definition, and will generate a > compile errror when CONFIG_ARM_LPAE=y > > For 32-bit ARM with CONFIG_ARM_LPAE=n, we don't have THP support and I noticed > some compiler errors in mm/madvise.c: > > CC mm/madvise.o > mm/madvise.c: In function ‘madvise_free_pte_range’: > mm/madvise.c:279:3: error: implicit declaration of function ‘pmdp_get_and_clear’ [-Werror=implicit-function-declaration] > orig_pmd = pmdp_get_and_clear(mm, addr, pmd); > ^ > mm/madvise.c:285:3: error: implicit declaration of function ‘pmd_mkold’ [-Werror=implicit-function-declaration] > orig_pmd = pmd_mkold(orig_pmd); > ^ > mm/madvise.c:286:3: error: implicit declaration of function ‘pmd_mkclean’ [-Werror=implicit-function-declaration] > orig_pmd = pmd_mkclean(orig_pmd); > ^ > mm/madvise.c:288:3: error: implicit declaration of function ‘set_pmd_at’ [-Werror=implicit-function-declaration] > set_pmd_at(mm, addr, pmd, orig_pmd); > ^ > cc1: some warnings being treated as errors > make[1]: *** [mm/madvise.o] Error 1 > Oops, will fix. Thanks for the review! > > Cheers, > -- > Steve > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Kind regards, Minchan Kim