From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH V2 2/2] ARM: dts: DRA7: Add node for RTC Date: Wed, 9 Jul 2014 03:09:15 -0700 Message-ID: <20140709100914.GL28884@atomide.com> References: <1404894932-26677-1-git-send-email-lokeshvutla@ti.com> <1404894932-26677-3-git-send-email-lokeshvutla@ti.com> <20140709091232.GJ28884@atomide.com> <53BD0C43.1090002@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:25629 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbaGIKJQ (ORCPT ); Wed, 9 Jul 2014 06:09:16 -0400 Content-Disposition: inline In-Reply-To: <53BD0C43.1090002@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Keerthy Cc: Lokesh Vutla , paul@pwsan.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@ti.com, devicetree@vger.kernel.org, nm@ti.com, j-keerthy@ti.com, nsekhar@ti.com * Keerthy [140709 02:36]: > On Wednesday 09 July 2014 02:42 PM, Tony Lindgren wrote: > >* Lokesh Vutla [140709 01:37]: > >>--- a/arch/arm/boot/dts/dra7-evm.dts > >>+++ b/arch/arm/boot/dts/dra7-evm.dts > >>@@ -249,6 +249,7 @@ > >> regulator-min-microvolt = <1050000>; > >> regulator-max-microvolt = <1050000>; > >> regulator-boot-on; > >>+ regulator-always-on; > >> }; > >Is this regulator really always on? > > This feeds on to RTC which is a free running clock. So i guess always on is > justified no? Well the dts entries should describe the hardware. If the regulator can be enabled and disabled, we should not claim it's always on. Also adding temporary dts entries just causes more churn on the dts files which is a PITA for everybody. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 9 Jul 2014 03:09:15 -0700 Subject: [PATCH V2 2/2] ARM: dts: DRA7: Add node for RTC In-Reply-To: <53BD0C43.1090002@ti.com> References: <1404894932-26677-1-git-send-email-lokeshvutla@ti.com> <1404894932-26677-3-git-send-email-lokeshvutla@ti.com> <20140709091232.GJ28884@atomide.com> <53BD0C43.1090002@ti.com> Message-ID: <20140709100914.GL28884@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Keerthy [140709 02:36]: > On Wednesday 09 July 2014 02:42 PM, Tony Lindgren wrote: > >* Lokesh Vutla [140709 01:37]: > >>--- a/arch/arm/boot/dts/dra7-evm.dts > >>+++ b/arch/arm/boot/dts/dra7-evm.dts > >>@@ -249,6 +249,7 @@ > >> regulator-min-microvolt = <1050000>; > >> regulator-max-microvolt = <1050000>; > >> regulator-boot-on; > >>+ regulator-always-on; > >> }; > >Is this regulator really always on? > > This feeds on to RTC which is a free running clock. So i guess always on is > justified no? Well the dts entries should describe the hardware. If the regulator can be enabled and disabled, we should not claim it's always on. Also adding temporary dts entries just causes more churn on the dts files which is a PITA for everybody. Regards, Tony