From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [GIT PULL 2/3] ARM: tegra: move fuse code out of arch/arm Date: Wed, 9 Jul 2014 14:50:01 +0200 Message-ID: <201407091450.02165.arnd@arndb.de> References: <1403558626-13422-1-git-send-email-swarren@wwwdotorg.org> <20140709111633.GG23218@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140709111633.GG23218-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter De Schrijver Cc: Olof Johansson , Greg Kroah-Hartman , Stephen Warren , "arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wednesday 09 July 2014, Peter De Schrijver wrote: > On Tue, Jul 08, 2014 at 07:47:16PM +0200, Olof Johansson wrote: > > On Tue, Jul 8, 2014 at 6:43 AM, Peter De Schrijver > > wrote: > > > On Mon, Jul 07, 2014 at 02:44:17AM +0200, Olof Johansson wrote: > > >> On Mon, Jun 23, 2014 at 03:23:45PM -0600, Stephen Warren wrote: > > >> > This branch moves code related to the Tegra fuses out of arch/arm and > > >> > into a centralized location which could be shared with ARM64. It also > > >> > adds support for reading the fuse data through sysfs. > > >> > > >> The new/moved misc driver isn't acked by any misc maintainer, so I can't > > >> take this branch. > > >> > > >> I saw no indication from searching the mailing list of that either, > > >> so it wasn't just a missed acked-by. > > >> > > >> I wonder if this code should go under drivers/soc/ instead? > > > > > > It's modelled after sunxi_sid.c which lives in drivers/misc/eeprom/. > > > Originally this driver was also in drivers/misc/eeprom/, but Stephen objected > > > and therefore it was moved to drivers/misc/fuse. I think that's the right > > > place still. > > > > I disagree, I think this belongs under drivers/soc. Especially since > > you're adding dependencies on this misc driver from other parts of the > > kernel / other drivers. > > > > There are several other drivers doing that already, eg: > > drivers/misc/eeprom/eeprom_93cx6.c > drivers/misc/atmel-ssc.c > drivers/misc/atmel_pwm.c I believe we have plans to remove the latter two. I don't know about the eeprom one. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 9 Jul 2014 14:50:01 +0200 Subject: [GIT PULL 2/3] ARM: tegra: move fuse code out of arch/arm In-Reply-To: <20140709111633.GG23218@tbergstrom-lnx.Nvidia.com> References: <1403558626-13422-1-git-send-email-swarren@wwwdotorg.org> <20140709111633.GG23218@tbergstrom-lnx.Nvidia.com> Message-ID: <201407091450.02165.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 09 July 2014, Peter De Schrijver wrote: > On Tue, Jul 08, 2014 at 07:47:16PM +0200, Olof Johansson wrote: > > On Tue, Jul 8, 2014 at 6:43 AM, Peter De Schrijver > > wrote: > > > On Mon, Jul 07, 2014 at 02:44:17AM +0200, Olof Johansson wrote: > > >> On Mon, Jun 23, 2014 at 03:23:45PM -0600, Stephen Warren wrote: > > >> > This branch moves code related to the Tegra fuses out of arch/arm and > > >> > into a centralized location which could be shared with ARM64. It also > > >> > adds support for reading the fuse data through sysfs. > > >> > > >> The new/moved misc driver isn't acked by any misc maintainer, so I can't > > >> take this branch. > > >> > > >> I saw no indication from searching the mailing list of that either, > > >> so it wasn't just a missed acked-by. > > >> > > >> I wonder if this code should go under drivers/soc/ instead? > > > > > > It's modelled after sunxi_sid.c which lives in drivers/misc/eeprom/. > > > Originally this driver was also in drivers/misc/eeprom/, but Stephen objected > > > and therefore it was moved to drivers/misc/fuse. I think that's the right > > > place still. > > > > I disagree, I think this belongs under drivers/soc. Especially since > > you're adding dependencies on this misc driver from other parts of the > > kernel / other drivers. > > > > There are several other drivers doing that already, eg: > > drivers/misc/eeprom/eeprom_93cx6.c > drivers/misc/atmel-ssc.c > drivers/misc/atmel_pwm.c I believe we have plans to remove the latter two. I don't know about the eeprom one. Arnd