All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: fix hsw_write_dcomp() error message
Date: Wed, 9 Jul 2014 17:16:30 +0100	[thread overview]
Message-ID: <20140709161630.GD341@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1404485998-4580-1-git-send-email-przanoni@gmail.com>

On Fri, Jul 04, 2014 at 11:59:57AM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> That function can be used to write anything on D_COMP, not just
> disable it, so print a more appropriate message.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c12a5da..6986594 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7370,7 +7370,7 @@ static void hsw_write_dcomp(struct drm_i915_private *dev_priv, uint32_t val)
>  		mutex_lock(&dev_priv->rps.hw_lock);
>  		if (sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_D_COMP,
>  					    val))
> -			DRM_ERROR("Failed to disable D_COMP\n");
> +			DRM_ERROR("Failed to write to D_COMP\n");
>  		mutex_unlock(&dev_priv->rps.hw_lock);
>  	} else {
>  		I915_WRITE(D_COMP, val);
> -- 
> 2.0.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2014-07-09 16:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 14:59 [PATCH 1/2] drm/i915: fix hsw_write_dcomp() error message Paulo Zanoni
2014-07-04 14:59 ` [PATCH 2/2] drm/i915: fix D_COMP usage on BDW Paulo Zanoni
2014-07-09 16:35   ` Damien Lespiau
2014-07-10  6:28     ` Daniel Vetter
2014-07-09 16:16 ` Damien Lespiau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140709161630.GD341@strange.amr.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=przanoni@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.