* [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE
@ 2014-07-04 5:47 Vinod Koul
2014-07-04 11:47 ` Mark Brown
2014-07-04 16:53 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Vinod Koul @ 2014-07-04 5:47 UTC (permalink / raw)
To: alsa-devel; +Cc: Vinod Koul, Praveen Diwakar, broonie, lgirdwood
From: Praveen Diwakar <praveen.diwakar@intel.com>
Since MODULE_LICENSE is missing the module load fails,
so add this for module.
Signed-off-by: Praveen Diwakar <praveen.diwakar@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
---
sound/soc/codecs/wm_adsp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 0600271..2537725 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
return 0;
}
EXPORT_SYMBOL_GPL(wm_adsp2_init);
+
+MODULE_LICENSE("GPL v2");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE
2014-07-04 5:47 [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE Vinod Koul
@ 2014-07-04 11:47 ` Mark Brown
2014-07-04 12:47 ` Charles Keepax
2014-07-04 16:53 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2014-07-04 11:47 UTC (permalink / raw)
To: Vinod Koul; +Cc: alsa-devel, patches, Praveen Diwakar, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 917 bytes --]
On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote:
> From: Praveen Diwakar <praveen.diwakar@intel.com>
>
> Since MODULE_LICENSE is missing the module load fails,
> so add this for module.
Always CC maintainers on patches (in this case the Wolfson people),
especially for something like licensing.
> Signed-off-by: Praveen Diwakar <praveen.diwakar@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> ---
> sound/soc/codecs/wm_adsp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
> index 0600271..2537725 100644
> --- a/sound/soc/codecs/wm_adsp.c
> +++ b/sound/soc/codecs/wm_adsp.c
> @@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
> return 0;
> }
> EXPORT_SYMBOL_GPL(wm_adsp2_init);
> +
> +MODULE_LICENSE("GPL v2");
> --
> 1.7.0.4
>
>
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE
2014-07-04 11:47 ` Mark Brown
@ 2014-07-04 12:47 ` Charles Keepax
2014-07-09 16:39 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Charles Keepax @ 2014-07-04 12:47 UTC (permalink / raw)
To: Mark Brown; +Cc: Vinod Koul, alsa-devel, patches, Praveen Diwakar, lgirdwood
On Fri, Jul 04, 2014 at 12:47:23PM +0100, Mark Brown wrote:
> On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote:
> > From: Praveen Diwakar <praveen.diwakar@intel.com>
> >
> > Since MODULE_LICENSE is missing the module load fails,
> > so add this for module.
>
> Always CC maintainers on patches (in this case the Wolfson people),
> especially for something like licensing.
Indeed we would definitely like to be in the loop on licensing
changes :-)
>
> > Signed-off-by: Praveen Diwakar <praveen.diwakar@intel.com>
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> > ---
> > sound/soc/codecs/wm_adsp.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
> > index 0600271..2537725 100644
> > --- a/sound/soc/codecs/wm_adsp.c
> > +++ b/sound/soc/codecs/wm_adsp.c
> > @@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
> > return 0;
> > }
> > EXPORT_SYMBOL_GPL(wm_adsp2_init);
> > +
> > +MODULE_LICENSE("GPL v2");
Yeah this is fine, I have been meaning to do that myself.
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE
2014-07-04 5:47 [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE Vinod Koul
2014-07-04 11:47 ` Mark Brown
@ 2014-07-04 16:53 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2014-07-04 16:53 UTC (permalink / raw)
To: Vinod Koul; +Cc: alsa-devel, Praveen Diwakar, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 223 bytes --]
On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote:
> From: Praveen Diwakar <praveen.diwakar@intel.com>
>
> Since MODULE_LICENSE is missing the module load fails,
> so add this for module.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE
2014-07-04 12:47 ` Charles Keepax
@ 2014-07-09 16:39 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2014-07-09 16:39 UTC (permalink / raw)
To: Charles Keepax
Cc: alsa-devel, Mark Brown, Praveen Diwakar, patches, lgirdwood
On Fri, Jul 04, 2014 at 01:47:24PM +0100, Charles Keepax wrote:
> On Fri, Jul 04, 2014 at 12:47:23PM +0100, Mark Brown wrote:
> > On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote:
> > > From: Praveen Diwakar <praveen.diwakar@intel.com>
> > >
> > > Since MODULE_LICENSE is missing the module load fails,
> > > so add this for module.
> >
> > Always CC maintainers on patches (in this case the Wolfson people),
> > especially for something like licensing.
>
> Indeed we would definitely like to be in the loop on licensing
> changes :-)
Sorry about missing you folks on this. Somehow still mind equated wm with Mark.
We should let get_maintainers do this, always :)
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-09 16:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-04 5:47 [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE Vinod Koul
2014-07-04 11:47 ` Mark Brown
2014-07-04 12:47 ` Charles Keepax
2014-07-09 16:39 ` Vinod Koul
2014-07-04 16:53 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.