From: Greg KH <gregkh@linuxfoundation.org>
To: Sami Laine <laine.j.sami@gmail.com>
Cc: sachin.kamat@linaro.org, devel@driverdev.osuosl.org,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction
Date: Wed, 9 Jul 2014 12:23:27 -0700 [thread overview]
Message-ID: <20140709192327.GA4593@kroah.com> (raw)
In-Reply-To: <20140706090553.GB16760@acer>
On Sun, Jul 06, 2014 at 12:05:53PM +0300, Sami Laine wrote:
> From: Sami Laine <laine.j.sami@gmail.com>
>
> Sparse warning correction:
>
> vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
> not declared. Should it be static?
>
> Signed-off-by: Sami Laine <laine.j.sami@gmail.com>
> ---
> diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug
> index 8aefbf1..e4a19ba 100644
> --- a/drivers/staging/rtl8821ae/debug.c
> +++ b/drivers/staging/rtl8821ae/debug.c
> @@ -77,7 +77,7 @@ void rtl_dbgp_flag_init(struct ieee80211_hw *hw)
> /*Init Debug flag enable condition */
> }
>
> -struct proc_dir_entry *proc_topdir;
> +static struct proc_dir_entry *proc_topdir;
> static int rtl_proc_get_mac_0(struct seq_file *m, void *v)
> {
> struct ieee80211_hw *hw = m->private;
This does not apply properly, and given the lack of testing of your
other patch, I'm loath to try to fix it up by hand myself :(
greg k-h
prev parent reply other threads:[~2014-07-09 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 9:05 [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction Sami Laine
2014-07-09 19:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709192327.GA4593@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=laine.j.sami@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.