All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, namhyung@kernel.org,
	acme@infradead.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/9] perf, tools: Automatically look for event file name for cpu v3
Date: Thu, 10 Jul 2014 00:19:33 +0200	[thread overview]
Message-ID: <20140709221933.GF20938@krava.redhat.com> (raw)
In-Reply-To: <1403910964-11017-5-git-send-email-andi@firstfloor.org>

On Fri, Jun 27, 2014 at 04:15:59PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>

SNIP

> new file mode 100644
> index 0000000..e1cd76c
> --- /dev/null
> +++ b/tools/perf/arch/x86/util/cpustr.c
> @@ -0,0 +1,34 @@
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include "../../util/jevents.h"
> +
> +char *get_cpu_str(void)
> +{
> +	char *line = NULL;
> +	size_t llen = 0;
> +	int found = 0, n;
> +	char vendor[30];
> +	int model, fam;
> +	char *res = NULL;
> +	FILE *f = fopen("/proc/cpuinfo", "r");
> +
> +	if (!f)
> +		return NULL;
> +	while (getline(&line, &llen, f) > 0) {
> +		if (sscanf(line, "vendor_id : %30s", vendor) == 1)
> +			found++;
> +		else if (sscanf(line, "model : %d", &model) == 1)
> +			found++;
> +		else if (sscanf(line, "cpu family : %d", &fam) == 1)
> +			found++;
> +		if (found == 3) {
> +			n = asprintf(&res, "%s-%d-%X-core", vendor, fam, model);
> +			if (n < 0)
> +				res = NULL;
> +			break;
> +		}
> +	}
> +	free(line);
> +	fclose(f);
> +	return res;

we already have arch get_cpuid, which seems to do same thing via cpuid
it would be nice to share those if possible

jirka

  reply	other threads:[~2014-07-09 22:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 23:15 perf: Add support for full Intel event lists v7 Andi Kleen
2014-06-27 23:15 ` [PATCH 1/9] perf, tools: Add jsmn `jasmine' JSON parser v3 Andi Kleen
2014-06-27 23:15 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-07-09 22:19   ` Jiri Olsa
2014-07-11 22:55     ` Andi Kleen
2014-07-09 22:19   ` Jiri Olsa
2014-06-27 23:15 ` [PATCH 3/9] perf, tools: Add support for reading JSON event files v3 Andi Kleen
2014-07-09 22:19   ` Jiri Olsa
2014-07-09 22:19   ` Jiri Olsa
2014-07-09 22:19   ` Jiri Olsa
2014-07-10  0:05     ` Andi Kleen
2014-07-10  6:25       ` Jiri Olsa
2014-07-10 14:22         ` Andi Kleen
2014-07-09 22:20   ` Jiri Olsa
2014-07-10  0:06     ` Andi Kleen
2014-06-27 23:15 ` [PATCH 4/9] perf, tools: Automatically look for event file name for cpu v3 Andi Kleen
2014-07-09 22:19   ` Jiri Olsa [this message]
2014-06-27 23:16 ` [PATCH 5/9] perf, tools: Add perf download to download event files v4 Andi Kleen
2014-07-09 22:20   ` Jiri Olsa
2014-07-10  0:07     ` Andi Kleen
2014-06-27 23:16 ` [PATCH 6/9] perf, tools: Allow events with dot Andi Kleen
2014-07-09 22:18   ` Jiri Olsa
2014-06-27 23:16 ` [PATCH 7/9] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-06-27 23:16 ` [PATCH 8/9] perf, tools, test: Add test case for alias and JSON parsing v2 Andi Kleen
2014-07-09 22:20   ` Jiri Olsa
2014-07-09 22:20   ` Jiri Olsa
2014-06-27 23:16 ` [PATCH 9/9] perf, tools: Add a --quiet flag to perf list Andi Kleen
2014-07-08 18:43 ` perf: Add support for full Intel event lists v7 Sukadev Bhattiprolu
2014-07-08 19:28   ` Andi Kleen
2014-07-08 21:49     ` Sukadev Bhattiprolu
2014-07-09 22:18 ` Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2014-06-13 23:02 perf: Add support for full Intel event lists v6 Andi Kleen
2014-06-13 23:02 ` [PATCH 4/9] perf, tools: Automatically look for event file name for cpu v3 Andi Kleen
2014-07-09  2:13   ` Sukadev Bhattiprolu
2014-07-09  4:07     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140709221933.GF20938@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.