diff for duplicates of <20140710000905.GA18025@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 36f38e5..83ef800 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -95,7 +95,7 @@ You should just remove a whole group at once, not individually. > +{ > + struct device *dev = get_cpu_device(cpu); > + -> + if (per_cpu_cacheinfo(cpu) = NULL) +> + if (per_cpu_cacheinfo(cpu) == NULL) > + return -ENOENT; > + > + per_cpu_cache_dev(cpu) = device_create(dev->class, dev, cpu, @@ -106,7 +106,7 @@ You should just remove a whole group at once, not individually. > + /* Allocate all required memory */ > + per_cpu_index_dev(cpu) = kzalloc(sizeof(struct device *) * > + cache_leaves(cpu), GFP_KERNEL); -> + if (unlikely(per_cpu_index_dev(cpu) = NULL)) +> + if (unlikely(per_cpu_index_dev(cpu) == NULL)) > + goto err_out; > + > + return 0; diff --git a/a/content_digest b/N1/content_digest index 99bf603..a5b3d68 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01403717444-23559-3-git-send-email-sudeep.holla@arm.com\0" "From\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" "Subject\0Re: [PATCH 2/9] drivers: base: support cpu cache information interface to userspace via sysfs\0" - "Date\0Thu, 10 Jul 2014 00:09:05 +0000\0" + "Date\0Wed, 9 Jul 2014 17:09:05 -0700\0" "To\0Sudeep Holla <sudeep.holla@arm.com>\0" "Cc\0linux-kernel@vger.kernel.org" Heiko Carstens <heiko.carstens@de.ibm.com> @@ -114,7 +114,7 @@ "> +{\n" "> +\tstruct device *dev = get_cpu_device(cpu);\n" "> +\n" - "> +\tif (per_cpu_cacheinfo(cpu) = NULL)\n" + "> +\tif (per_cpu_cacheinfo(cpu) == NULL)\n" "> +\t\treturn -ENOENT;\n" "> +\n" "> +\tper_cpu_cache_dev(cpu) = device_create(dev->class, dev, cpu,\n" @@ -125,7 +125,7 @@ "> +\t/* Allocate all required memory */\n" "> +\tper_cpu_index_dev(cpu) = kzalloc(sizeof(struct device *) *\n" "> +\t\t\t\t\t cache_leaves(cpu), GFP_KERNEL);\n" - "> +\tif (unlikely(per_cpu_index_dev(cpu) = NULL))\n" + "> +\tif (unlikely(per_cpu_index_dev(cpu) == NULL))\n" "> +\t\tgoto err_out;\n" "> +\n" "> +\treturn 0;\n" @@ -178,4 +178,4 @@ "I think if you fix up the is_visible() thing above, these calls will go\n" away, right? -8930e55271e070a43cbfa0effd66dc7f3a2055ffe6519005ea98ff823f29a46d +02373453cc9e107611d75b79184b7dd395d56f10c8d4f228b16be47401a22e46
diff --git a/a/1.txt b/N2/1.txt index 36f38e5..83ef800 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -95,7 +95,7 @@ You should just remove a whole group at once, not individually. > +{ > + struct device *dev = get_cpu_device(cpu); > + -> + if (per_cpu_cacheinfo(cpu) = NULL) +> + if (per_cpu_cacheinfo(cpu) == NULL) > + return -ENOENT; > + > + per_cpu_cache_dev(cpu) = device_create(dev->class, dev, cpu, @@ -106,7 +106,7 @@ You should just remove a whole group at once, not individually. > + /* Allocate all required memory */ > + per_cpu_index_dev(cpu) = kzalloc(sizeof(struct device *) * > + cache_leaves(cpu), GFP_KERNEL); -> + if (unlikely(per_cpu_index_dev(cpu) = NULL)) +> + if (unlikely(per_cpu_index_dev(cpu) == NULL)) > + goto err_out; > + > + return 0; diff --git a/a/content_digest b/N2/content_digest index 99bf603..d8a33fd 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,17 +2,17 @@ "ref\01403717444-23559-3-git-send-email-sudeep.holla@arm.com\0" "From\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" "Subject\0Re: [PATCH 2/9] drivers: base: support cpu cache information interface to userspace via sysfs\0" - "Date\0Thu, 10 Jul 2014 00:09:05 +0000\0" + "Date\0Wed, 9 Jul 2014 17:09:05 -0700\0" "To\0Sudeep Holla <sudeep.holla@arm.com>\0" - "Cc\0linux-kernel@vger.kernel.org" - Heiko Carstens <heiko.carstens@de.ibm.com> + "Cc\0Rob Herring <robh@kernel.org>" Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com> - Rob Herring <robh@kernel.org> - linux-doc@vger.kernel.org linux-ia64@vger.kernel.org - linux390@de.ibm.com + linux-doc@vger.kernel.org linux-s390@vger.kernel.org x86@kernel.org + Heiko Carstens <heiko.carstens@de.ibm.com> + linux-kernel@vger.kernel.org + linux390@de.ibm.com linuxppc-dev@lists.ozlabs.org " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" @@ -114,7 +114,7 @@ "> +{\n" "> +\tstruct device *dev = get_cpu_device(cpu);\n" "> +\n" - "> +\tif (per_cpu_cacheinfo(cpu) = NULL)\n" + "> +\tif (per_cpu_cacheinfo(cpu) == NULL)\n" "> +\t\treturn -ENOENT;\n" "> +\n" "> +\tper_cpu_cache_dev(cpu) = device_create(dev->class, dev, cpu,\n" @@ -125,7 +125,7 @@ "> +\t/* Allocate all required memory */\n" "> +\tper_cpu_index_dev(cpu) = kzalloc(sizeof(struct device *) *\n" "> +\t\t\t\t\t cache_leaves(cpu), GFP_KERNEL);\n" - "> +\tif (unlikely(per_cpu_index_dev(cpu) = NULL))\n" + "> +\tif (unlikely(per_cpu_index_dev(cpu) == NULL))\n" "> +\t\tgoto err_out;\n" "> +\n" "> +\treturn 0;\n" @@ -178,4 +178,4 @@ "I think if you fix up the is_visible() thing above, these calls will go\n" away, right? -8930e55271e070a43cbfa0effd66dc7f3a2055ffe6519005ea98ff823f29a46d +35a745e166dd9927c9676d770ab729ecf44934ab5022ec0035478da058d6222a
diff --git a/a/1.txt b/N3/1.txt index 36f38e5..83ef800 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -95,7 +95,7 @@ You should just remove a whole group at once, not individually. > +{ > + struct device *dev = get_cpu_device(cpu); > + -> + if (per_cpu_cacheinfo(cpu) = NULL) +> + if (per_cpu_cacheinfo(cpu) == NULL) > + return -ENOENT; > + > + per_cpu_cache_dev(cpu) = device_create(dev->class, dev, cpu, @@ -106,7 +106,7 @@ You should just remove a whole group at once, not individually. > + /* Allocate all required memory */ > + per_cpu_index_dev(cpu) = kzalloc(sizeof(struct device *) * > + cache_leaves(cpu), GFP_KERNEL); -> + if (unlikely(per_cpu_index_dev(cpu) = NULL)) +> + if (unlikely(per_cpu_index_dev(cpu) == NULL)) > + goto err_out; > + > + return 0; diff --git a/a/content_digest b/N3/content_digest index 99bf603..8579519 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,20 +1,9 @@ "ref\01403717444-23559-1-git-send-email-sudeep.holla@arm.com\0" "ref\01403717444-23559-3-git-send-email-sudeep.holla@arm.com\0" - "From\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" - "Subject\0Re: [PATCH 2/9] drivers: base: support cpu cache information interface to userspace via sysfs\0" - "Date\0Thu, 10 Jul 2014 00:09:05 +0000\0" - "To\0Sudeep Holla <sudeep.holla@arm.com>\0" - "Cc\0linux-kernel@vger.kernel.org" - Heiko Carstens <heiko.carstens@de.ibm.com> - Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com> - Rob Herring <robh@kernel.org> - linux-doc@vger.kernel.org - linux-ia64@vger.kernel.org - linux390@de.ibm.com - linux-s390@vger.kernel.org - x86@kernel.org - linuxppc-dev@lists.ozlabs.org - " linux-arm-kernel@lists.infradead.org\0" + "From\0gregkh@linuxfoundation.org (Greg Kroah-Hartman)\0" + "Subject\0[PATCH 2/9] drivers: base: support cpu cache information interface to userspace via sysfs\0" + "Date\0Wed, 9 Jul 2014 17:09:05 -0700\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Wed, Jun 25, 2014 at 06:30:37PM +0100, Sudeep Holla wrote:\n" @@ -114,7 +103,7 @@ "> +{\n" "> +\tstruct device *dev = get_cpu_device(cpu);\n" "> +\n" - "> +\tif (per_cpu_cacheinfo(cpu) = NULL)\n" + "> +\tif (per_cpu_cacheinfo(cpu) == NULL)\n" "> +\t\treturn -ENOENT;\n" "> +\n" "> +\tper_cpu_cache_dev(cpu) = device_create(dev->class, dev, cpu,\n" @@ -125,7 +114,7 @@ "> +\t/* Allocate all required memory */\n" "> +\tper_cpu_index_dev(cpu) = kzalloc(sizeof(struct device *) *\n" "> +\t\t\t\t\t cache_leaves(cpu), GFP_KERNEL);\n" - "> +\tif (unlikely(per_cpu_index_dev(cpu) = NULL))\n" + "> +\tif (unlikely(per_cpu_index_dev(cpu) == NULL))\n" "> +\t\tgoto err_out;\n" "> +\n" "> +\treturn 0;\n" @@ -178,4 +167,4 @@ "I think if you fix up the is_visible() thing above, these calls will go\n" away, right? -8930e55271e070a43cbfa0effd66dc7f3a2055ffe6519005ea98ff823f29a46d +7807cc0a439ae4056ef9e3cef1390eea1a11e9040620b37b17e7088e90995419
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.