From: Christoph Hellwig <hch@infradead.org>
To: Tomas Henzl <thenzl@redhat.com>
Cc: linux-scsi@vger.kernel.org, xjtuwjp@gmail.com,
Vasanthalakshmi.Tharmarajan@pmcs.com,
Suresh.Thiagarajan@pmcs.com, Viswas.G@pmcs.com
Subject: Re: [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw
Date: Wed, 9 Jul 2014 23:43:01 -0700 [thread overview]
Message-ID: <20140710064301.GA18156@infradead.org> (raw)
In-Reply-To: <1404746401-25229-4-git-send-email-thenzl@redhat.com>
On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote:
> The current implementation may mix the negative value returned
> from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted
> as bytes programmed, this patch fixes it.
This still doesn;t look correct to me as err mixes up the driver
internal FAIL_* codes with Linux error codes. It seems like for the
FAIL_* codes should only go into ->fw_status and the return value
should be a proper Linux error code.
Funny fact: the FAIL_* / FLASH_IN_PROGRESS codes seems to be the same
between aic94xx and pm8001.
next prev parent reply other threads:[~2014-07-10 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 15:20 [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw Tomas Henzl
2014-07-10 6:43 ` Christoph Hellwig [this message]
2014-07-10 13:30 ` Tomas Henzl
2014-07-30 13:13 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710064301.GA18156@infradead.org \
--to=hch@infradead.org \
--cc=Suresh.Thiagarajan@pmcs.com \
--cc=Vasanthalakshmi.Tharmarajan@pmcs.com \
--cc=Viswas.G@pmcs.com \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.