From: Wolfram Sang <wsa@the-dreams.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator
Date: Thu, 10 Jul 2014 09:40:24 +0000 [thread overview]
Message-ID: <20140710094024.GA2728@katana> (raw)
In-Reply-To: <53B5F327.5040301@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
> Wolfram, can you give us your opinion about this patch? Does it
> improve our I2C software support on Lager?
Yes, it does. Khiem-san is right, IIC3 is dedicated to DVFS, so it
should be activated. From that point of view:
Reviewed-by: Wolfram Sang <wsa@sang-engineering.com>
However, I sadly missed commit e489c2a9bc82713167d9f721ca764f4b0d37e543
("ARM: shmobile: lager: enable i2c devices") which enables i2c cores for
all busses. I do like the iic cores better because of SMBUS_QUICK
support and DMA capability (although not yet supported). i2c cores have
slave support as an advantage, yet they can be switched in when that is
actually needed (still needs to be implemented, too). So, it might make
sense to switch all busses to iic, I'd say.
All the best,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-10 9:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 0:19 [PATCH v2] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator Khiem Nguyen
2014-07-04 5:40 ` Gaku Inami
2014-07-04 6:41 ` Khiem Nguyen
2014-07-06 14:37 ` Simon Horman
2014-07-06 14:58 ` Simon Horman
2014-07-06 22:39 ` Khiem Nguyen
2014-07-10 8:23 ` Magnus Damm
2014-07-10 8:43 ` Khiem Nguyen
2014-07-10 9:40 ` Wolfram Sang [this message]
2014-07-10 9:46 ` Magnus Damm
2014-07-10 10:01 ` Khiem Nguyen
2014-07-10 10:03 ` Magnus Damm
2014-07-11 8:45 ` Simon Horman
2014-07-13 23:19 ` Khiem Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710094024.GA2728@katana \
--to=wsa@the-dreams.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.