From: Matthieu CASTET <matthieu.castet@parrot.com>
To: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: Chris Ball <cjb@laptop.org>
Subject: Re: [RFC 1/2] sdhci : recompute timeout_clk when needed
Date: Thu, 10 Jul 2014 10:03:20 +0200 [thread overview]
Message-ID: <20140710100320.77697cfe@parrot.com> (raw)
In-Reply-To: <1404979264-8070-1-git-send-email-matthieu.castet@parrot.com>
Please ignore this mail, it is a mistake (it was already sent).
Sorry for the noise.
Le Thu, 10 Jul 2014 10:01:03 +0200,
Matthieu CASTET <matthieu.castet@parrot.com> a écrit :
> when SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set, timeout_clk is sdclk.
> We need to update it when we change sdclk in sdhci_set_clock.
> This allow to have a more precisse timeout and max_busy_timeout. This
> can help for command that need a big busy wait (erase, ...).
>
> Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
> ---
> drivers/mmc/host/sdhci.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 9df59a4..76b1aab 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1192,8 +1192,13 @@ void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
> }
>
> clock_set:
> - if (real_div)
> + if (real_div) {
> host->mmc->actual_clock = (host->max_clk * clk_mul) / real_div;
> + if (host->quirks & SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK) {
> + host->timeout_clk = host->mmc->actual_clock / 1000;
> + host->mmc->max_busy_timeout = (1 << 27) / host->timeout_clk;
> + }
> + }
>
> clk |= (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT;
> clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN)
prev parent reply other threads:[~2014-07-10 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 8:01 [RFC 1/2] sdhci : recompute timeout_clk when needed Matthieu CASTET
2014-07-10 8:03 ` Matthieu CASTET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710100320.77697cfe@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.