From: Patrick McHardy <kaber@trash.net>
To: Giorgio Dal Molin <giorgio.nicole@arcor.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/7] autotools conversion: include the header 'config.h' in every C source file.
Date: Thu, 10 Jul 2014 12:04:09 +0200 [thread overview]
Message-ID: <20140710100409.GA13741@macbook.localnet> (raw)
In-Reply-To: <1404742796-8039-5-git-send-email-giorgio.nicole@arcor.de>
On Mon, Jul 07, 2014 at 04:19:28PM +0200, Giorgio Dal Molin wrote:
> Added an #include <config.h> to all the C source files so that the results
> of the tests in the configure script are available to all the compilation
> units.
>
> We could have added the include also to 'yacc_parser.y' and 'scanner.l'
> but we don't, because it is not strictly needed and to avoid to define
> the variable 'VERSION' two times.
> --- a/src/cli.c
> +++ b/src/cli.c
> @@ -11,6 +11,9 @@
> *
> * Development of this code funded by Astaro AG (http://www.astaro.com/)
> */
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
Do we really need those ifdefs?
next prev parent reply other threads:[~2014-07-10 10:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 14:19 [PATCH 0/7] patches for an autotooled version of 'nftables'. (vers. 2) Giorgio Dal Molin
2014-07-07 14:19 ` [PATCH 1/7] autotool conversion: autotools support for the subdir. 'files/nftables' Giorgio Dal Molin
2014-07-07 14:19 ` [PATCH 2/7] autotool conversion: use pkg-config to find 'libmnl', libnftnl' and 'ncurses' Giorgio Dal Molin
2014-07-07 14:19 ` [PATCH 3/7] autotool conversion: converted the subdir. 'src/' Giorgio Dal Molin
2014-07-10 10:08 ` Pablo Neira Ayuso
2014-07-10 10:42 ` Giorgio Dal Molin
2014-07-07 14:19 ` [PATCH 4/7] autotools conversion: include the header 'config.h' in every C source file Giorgio Dal Molin
2014-07-10 10:04 ` Patrick McHardy [this message]
2014-07-11 7:24 ` Jan Engelhardt
2014-07-07 14:19 ` [PATCH 5/7] autotool conversion: Converted the support for the 'doc/' subdir Giorgio Dal Molin
2014-07-07 14:19 ` [PATCH 6/7] autotools conversion: commit the rest of the configure.ac changes Giorgio Dal Molin
2014-07-07 14:19 ` [PATCH 7/7] autotool conversion: updated the files .gitignore Giorgio Dal Molin
2014-07-25 17:16 ` [PATCH 0/7] patches for an autotooled version of 'nftables'. (vers. 2) Pablo Neira Ayuso
2014-07-25 21:53 ` [PATCH 0/8] patches for an autotooled version of 'nftables' Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 1/8] autotool conversion: Added some required files, removed some unneeded Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 2/8] autotool conversion: autotools support for the subdir. 'files/nftables' Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 3/8] autotool conversion: use pkg-config to find 'libmnl', libnftnl' and 'ncurses' Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 4/8] autotool conversion: converted the subdir. 'src/' Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 5/8] autotools conversion: include the header 'config.h' in every C source file Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 6/8] autotool conversion: Converted the support for the 'doc/' subdir Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 7/8] autotools conversion: commit the rest of the configure.ac changes Giorgio Dal Molin
2014-07-25 21:53 ` [PATCH 8/8] autotool conversion: updated the files .gitignore Giorgio Dal Molin
-- strict thread matches above, loose matches on Subject: below --
2014-07-07 10:16 [PATCH 0/7] patches for an autotooled version of 'nftables' Giorgio Dal Molin
2014-07-07 10:16 ` [PATCH 4/7] autotools conversion: include the header 'config.h' in every C source file Giorgio Dal Molin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710100409.GA13741@macbook.localnet \
--to=kaber@trash.net \
--cc=giorgio.nicole@arcor.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.