From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Goode Date: Thu, 10 Jul 2014 11:12:53 +0000 Subject: Re: [PATCH] usb: usb5303: make use of uninitialized err variable Message-Id: <20140710111253.GA5352@lianli> List-Id: References: <1401731125-19780-1-git-send-email-emilgoode@gmail.com> <20140709224647.GA23929@kroah.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Mark Brown , Olof Johansson , Dongjin Kim , Julius Werner , Marek Szyprowski , USB list , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Hello Greg and Geert, On Thu, Jul 10, 2014 at 09:38:00AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman > wrote: > > On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote: > >> The variable err is not initialized here, this patch uses it > >> to store an eventual error value from devm_clk_get(). > >> > >> Signed-off-by: Emil Goode > >> Acked-by: Geert Uytterhoeven > >> --- > >> drivers/usb/misc/usb3503.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > > > This patch fails to apply to my tree :( > > You've already applied > commit ec5734c41bee2ee7c938a8f34853d31cada7e67a > Author: Tushar Behera > Date: Tue Jun 17 16:38:50 2014 +0530 > > usb: misc: usb3503: Update error code in print message > > 'err' is uninitialized, rather print the error code directly. > > which fixes it slightly different. Yes, my patch was sent about two weeks earlier, but of course please pick the one you think is best. Best regards, Emil Goode From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbaGJLNN (ORCPT ); Thu, 10 Jul 2014 07:13:13 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:60943 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbaGJLNL (ORCPT ); Thu, 10 Jul 2014 07:13:11 -0400 Date: Thu, 10 Jul 2014 13:12:53 +0200 From: Emil Goode To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Mark Brown , Olof Johansson , Dongjin Kim , Julius Werner , Marek Szyprowski , USB list , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] usb: usb5303: make use of uninitialized err variable Message-ID: <20140710111253.GA5352@lianli> References: <1401731125-19780-1-git-send-email-emilgoode@gmail.com> <20140709224647.GA23929@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg and Geert, On Thu, Jul 10, 2014 at 09:38:00AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman > wrote: > > On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote: > >> The variable err is not initialized here, this patch uses it > >> to store an eventual error value from devm_clk_get(). > >> > >> Signed-off-by: Emil Goode > >> Acked-by: Geert Uytterhoeven > >> --- > >> drivers/usb/misc/usb3503.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > > > This patch fails to apply to my tree :( > > You've already applied > commit ec5734c41bee2ee7c938a8f34853d31cada7e67a > Author: Tushar Behera > Date: Tue Jun 17 16:38:50 2014 +0530 > > usb: misc: usb3503: Update error code in print message > > 'err' is uninitialized, rather print the error code directly. > > which fixes it slightly different. Yes, my patch was sent about two weeks earlier, but of course please pick the one you think is best. Best regards, Emil Goode