From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lauri Kasanen <cand@gmx.com>
Subject: Re: [PATCH] drm/radeon: Inline r100_mm_rreg, -wreg, v3
Date: Thu, 10 Jul 2014 11:48:31 +0300
Message-ID: <20140710114831.a89f9c83.cand@gmx.com>
References: <20140420202933.78b3e355.cand@gmx.com>
 <535406B7.3090309@vodafone.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mout.gmx.com (mout.gmx.com [74.208.4.200])
 by gabe.freedesktop.org (Postfix) with ESMTP id 77D906E0B9
 for <dri-devel@lists.freedesktop.org>; Thu, 10 Jul 2014 01:46:57 -0700 (PDT)
In-Reply-To: <535406B7.3090309@vodafone.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Christian =?ISO-8859-15?Q?K=F6nig?= <deathsimple@vodafone.de>, Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Sun, 20 Apr 2014 19:41:11 +0200
Christian K=F6nig <deathsimple@vodafone.de> wrote:

> Am 20.04.2014 19:29, schrieb Lauri Kasanen:
> > This was originally un-inlined by Andi Kleen in 2011 citing size concer=
ns.
> > Indeed, a first attempt at inlining it grew radeon.ko by 7%.
> >
> > However, 2% of cpu is spent in this function. Simply inlining it gave 1=
% more fps
> > in Urban Terror.
> >
> > v2: We know the minimum MMIO size. Adding it to the if allows the compi=
ler to
> > optimize the branch out, improving both performance and size.
> >
> > The v2 patch decreases radeon.ko size by 2%. I didn't re-benchmark, but=
 common sense
> > says perf is now more than 1% better.
> >
> > v3: Also change _wreg, make the threshold a define.
> >
> > Inlining _wreg increased the size a bit compared to v2, so now radeon.ko
> > is only 1% smaller.
> >
> > Signed-off-by: Lauri Kasanen <cand@gmx.com>
> =

> Reviewed-by: Christian K=F6nig <christian.koenig@amd.com>

Ping. Although reviewed in April, seems this wasn't applied to any tree?

- Lauri