Re: [meta-oe][PATCH v2 2/2] usb-modeswitch: Upgrade to latest version

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Thu, Jul 10, 2014 at 04:16:20PM +0300, Jukka Rissanen wrote:
> On to, 2014-07-10 at 14:06 +0200, Martin Jansa wrote:
> > On Thu, Jul 10, 2014 at 02:09:35PM +0300, Jukka Rissanen wrote:
> > > Use the latest version of usb-modeswitch (2.2.0) and
> > > usb-modeswitch-data (20140529). The data package depends
> > > on new usb-modeswitch version so upgrade both of them at
> > > the same time.
> > > 
> > >  
> > > -RDEPENDS_${PN} = "usb-modeswitch"
> > > +RDEPENDS_${PN} = "usb-modeswitch (>= 2.2.0)"
> > 
> > Do we really need the version here?
> > 
> > If yes then add comment explaining why.
> 
> 
> Hmm, I thought the commit message already states that. Do you want that
> also in the recipe itself?

I read it as explanation why you're upgrading 2 recipes in the same
commit, but it doesn't say why you need explicit version in
RDEPENDS_${PN} (instead of letting bitbake do it automatically).

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]