All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Giorgio Dal Molin <giorgio.nicole@arcor.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] autotools conversion: include the header 'config.h' in every C source file.
Date: Thu, 10 Jul 2014 16:54:26 +0200	[thread overview]
Message-ID: <20140710145426.GA23419@localhost> (raw)
In-Reply-To: <1405001313-12902-1-git-send-email-giorgio.nicole@arcor.de>

On Thu, Jul 10, 2014 at 04:08:08PM +0200, Giorgio Dal Molin wrote:
> Added an #include <config.h> to all the C source files so that the results
> of the tests in the configure script are available to all the compilation
> units.

I think we can avoid this by passing the configuration options to the
compiler via -D instead of via config.h file.

https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Configuration-Headers.html

Any reason not to do it that way?

Thanks.

  reply	other threads:[~2014-07-10 14:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 10:32 Aw: Re: [PATCH 4/7] autotools conversion: include the header 'config.h' in every C source file giorgio.nicole
2014-07-10 12:52 ` Patrick McHardy
2014-07-10 13:57   ` Aw: " giorgio.nicole
2014-07-10 14:08   ` [PATCH] " Giorgio Dal Molin
2014-07-10 14:54     ` Pablo Neira Ayuso [this message]
2014-07-12  9:09       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710145426.GA23419@localhost \
    --to=pablo@netfilter.org \
    --cc=giorgio.nicole@arcor.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.