From: Vinod Koul <vinod.koul@intel.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH V2] dmaengine: inherit debug settings from the subsystem for subdirectories
Date: Fri, 11 Jul 2014 06:12:51 +0000 [thread overview]
Message-ID: <20140711060051.GH2296@intel.com> (raw)
In-Reply-To: <1405024603-4023-1-git-send-email-wsa@the-dreams.de>
On Thu, Jul 10, 2014 at 10:36:43PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> To be able to see debug messages during boot, enable the debug settings
> from Kconfig also for drivers in subdirectories.
Thanks, and this made me think. Can't we specify that these flags should
be inherited in subdirectories as well.
Going thru Kbuild doc again, looks like we can do this using subdir-ccflags-, so
the below patch can be simplified by doing
subdir-ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
subdir-ccflags-$(CONFIG_DMADEVICES_VDEBUG) := -DVERBOSE_DEBUG
That way we don't need to add to subdirectories and future directory changes will
auto get these flags
--
~Vinod
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since initial version:
>
> * extended to all subdirs (but only tested with sh)
> * give reason in commit message
>
> drivers/dma/bestcomm/Makefile | 3 +++
> drivers/dma/dw/Makefile | 3 +++
> drivers/dma/ioat/Makefile | 3 +++
> drivers/dma/ipu/Makefile | 3 +++
> drivers/dma/ppc4xx/Makefile | 3 +++
> drivers/dma/sh/Makefile | 3 +++
> drivers/dma/xilinx/Makefile | 3 +++
> 7 files changed, 21 insertions(+)
>
> diff --git a/drivers/dma/bestcomm/Makefile b/drivers/dma/bestcomm/Makefile
> index aed2df2a6580..61aab44d205a 100644
> --- a/drivers/dma/bestcomm/Makefile
> +++ b/drivers/dma/bestcomm/Makefile
> @@ -2,6 +2,9 @@
> # Makefile for BestComm & co
> #
>
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> bestcomm-core-objs := bestcomm.o sram.o
> bestcomm-ata-objs := ata.o bcom_ata_task.o
> bestcomm-fec-objs := fec.o bcom_fec_rx_task.o bcom_fec_tx_task.o
> diff --git a/drivers/dma/dw/Makefile b/drivers/dma/dw/Makefile
> index 3eebd1ce2c6b..1301d24615a5 100644
> --- a/drivers/dma/dw/Makefile
> +++ b/drivers/dma/dw/Makefile
> @@ -1,3 +1,6 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-$(CONFIG_DW_DMAC_CORE) += dw_dmac_core.o
> dw_dmac_core-objs := core.o
>
> diff --git a/drivers/dma/ioat/Makefile b/drivers/dma/ioat/Makefile
> index 0ff7270af25b..163618fdfd7a 100644
> --- a/drivers/dma/ioat/Makefile
> +++ b/drivers/dma/ioat/Makefile
> @@ -1,2 +1,5 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-$(CONFIG_INTEL_IOATDMA) += ioatdma.o
> ioatdma-y := pci.o dma.o dma_v2.o dma_v3.o dca.o
> diff --git a/drivers/dma/ipu/Makefile b/drivers/dma/ipu/Makefile
> index 6704cf48326d..07dea0b0228f 100644
> --- a/drivers/dma/ipu/Makefile
> +++ b/drivers/dma/ipu/Makefile
> @@ -1 +1,4 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-y += ipu_irq.o ipu_idmac.o
> diff --git a/drivers/dma/ppc4xx/Makefile b/drivers/dma/ppc4xx/Makefile
> index b3d259b3e52a..acd081dbf16a 100644
> --- a/drivers/dma/ppc4xx/Makefile
> +++ b/drivers/dma/ppc4xx/Makefile
> @@ -1 +1,4 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-$(CONFIG_AMCC_PPC440SPE_ADMA) += adma.o
> diff --git a/drivers/dma/sh/Makefile b/drivers/dma/sh/Makefile
> index 1ce88b28cfc6..275297a89bd5 100644
> --- a/drivers/dma/sh/Makefile
> +++ b/drivers/dma/sh/Makefile
> @@ -1,3 +1,6 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-$(CONFIG_SH_DMAE_BASE) += shdma-base.o shdma-of.o
> obj-$(CONFIG_SH_DMAE) += shdma.o
> shdma-y := shdmac.o
> diff --git a/drivers/dma/xilinx/Makefile b/drivers/dma/xilinx/Makefile
> index 3c4e9f2fea28..a169981e73e3 100644
> --- a/drivers/dma/xilinx/Makefile
> +++ b/drivers/dma/xilinx/Makefile
> @@ -1 +1,4 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-$(CONFIG_XILINX_VDMA) += xilinx_vdma.o
> --
> 2.0.0
>
--
next prev parent reply other threads:[~2014-07-11 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 20:36 [PATCH V2] dmaengine: inherit debug settings from the subsystem for subdirectories Wolfram Sang
2014-07-11 6:12 ` Vinod Koul [this message]
2014-07-11 7:28 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711060051.GH2296@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.