From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH i-g-t 05/43] igt_kms: Add support for
 setting plane rotation
Date: Fri, 11 Jul 2014 09:00:23 +0200
Message-ID: <20140711070023.GU17271@phenom.ffwll.local>
References: <1405015244-11370-1-git-send-email-damien.lespiau@intel.com>
 <1405015244-11370-6-git-send-email-damien.lespiau@intel.com>
 <20140711064029.GT17271@phenom.ffwll.local>
 <20140711064256.GT8986@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175])
 by gabe.freedesktop.org (Postfix) with ESMTP id CB85F6E7F7
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Jul 2014 00:00:16 -0700 (PDT)
Received: by mail-we0-f175.google.com with SMTP id k48so596085wev.34
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Jul 2014 00:00:14 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140711064256.GT8986@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, Damien Lespiau <damien.lespiau@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jul 11, 2014 at 07:42:56AM +0100, Chris Wilson wrote:
> On Fri, Jul 11, 2014 at 08:40:29AM +0200, Daniel Vetter wrote:
> > On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote:
> > > +typedef enum {
> > > +	/* this maps to the kernel API */
> > > +	IGT_ROTATION_0   = 1 << 0,
> > > +	IGT_ROTATION_90  = 1 << 1,
> > > +	IGT_ROTATION_180 = 1 << 2,
> > > +	IGT_ROTATION_270 = 1 << 3,
> > > +} igt_rotation_t;
> > 
> > Should we also add the flip X/Y bits, even if we currently don't support
> > this in the kernel?
> 
> Presumably there are tests in here to check the kernel rejects
> unsupported combination of rotations and unknown reflections? In which,
> yes.

I guess we should try everything and check whether it either gets rejected
or works properly ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch