From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [libvirt bisection] complete build-amd64-libvirt
Date: Fri, 11 Jul 2014 09:23:18 +0200
Message-ID: <20140711072318.GA21265@aepfle.de>
References: <E1X5Uua-0005vH-LW@osstest.cam.xci-test.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <E1X5Uua-0005vH-LW@osstest.cam.xci-test.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "xen.org" <Ian.Jackson@eu.citrix.com>, Jim Fehlig <jfehlig@suse.com>
Cc: xen-devel@lists.xensource.com, keir@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 11, xen.org wrote:

>   commit 4e7e5e9f7b29ef1c6924116e045a9b2c4bd3ea1a
>   Author: Olaf Hering <olaf@aepfle.de>
>   Date:   Mon Jul 7 17:05:17 2014 +0200
>   
>       libxl: add discard support to libxl_device_disk

This used to work for me. What has changed?

libxl/libxl_conf.c: In function 'libxlDiskSetDiscard':
libxl/libxl_conf.c:724:19: error: conversion to incomplete type
make[3]: *** [libxl/libvirt_driver_libxl_impl_la-libxl_conf.lo] Error 1

 718 static int
 719 libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
 720 {
 721     if (!x_disk->readwrite)
 722         return 0;
 723 #if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE)
 724     switch ((enum virDomainDiskDiscard)discard) {
 725     case VIR_DOMAIN_DISK_DISCARD_DEFAULT:
 726     case VIR_DOMAIN_DISK_DISCARD_LAST:


Olaf