From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: drm/vmwgfx: Fix compat shader namespace Date: Fri, 11 Jul 2014 11:43:01 +0300 Message-ID: <20140711084301.GM23001@mwanda> References: <20140709124807.GA7707@mwanda> <53BDB4C1.7090309@vmware.com> <20140710093318.GJ23001@mwanda> <53BF1041.5000103@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTP id 483556E105 for ; Fri, 11 Jul 2014 01:43:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53BF1041.5000103@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas =?iso-8859-1?Q?Hellstr=F6m?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Jul 11, 2014 at 12:14:25AM +0200, Thomas Hellstr=F6m wrote: > = > I agree, however that readability may be more important than the > fastpath execution speed gained from this. But in my case not so > much that I spontaneously feel like removing all branch prediction > hints from the vmwgfx driver. I'm just saying, let's not add new ones. > = > > > >There are two rules of thumb for likely/unlikely: > > > > 1) Don't use it in the drivers/ directory. > > 2) Or don't use it without benchmarking it. > = > Could you point me to a document or some sort of reference? http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-Marc= h/025252.html regards, dan carpenter