From: Mark Brown <broonie@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jianqun <xjq@rock-chips.com>, Jim Davis <jim.epost@gmail.com>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
grant.likely@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: randconfig build error with next-20140710, in sound/soc/rockchip/rockchip_i2s.c
Date: Fri, 11 Jul 2014 13:42:31 +0100 [thread overview]
Message-ID: <20140711124231.GN30458@sirena.org.uk> (raw)
In-Reply-To: <20140711103221.70c856fb@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Fri, Jul 11, 2014 at 10:32:21AM +1000, Stephen Rothwell wrote:
> Who ever gave you that advice is wrong. You should always (except in
> very rare circumstances) include every header file that your code
> references things from. We have over 20 architectures and many, many
> possible configurations in the kernel build system and the fact that a
> file builds for one is not guarantee that it will build for another
> combination if you depend on implicit includes.
Right, I suspect this is coming from the header minimisation efforts :/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-07-11 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 13:53 randconfig build error with next-20140710, in sound/soc/rockchip/rockchip_i2s.c Jim Davis
[not found] ` <CA+r1ZhgB=BG5jsSaWBLMvRUjZ=X4gKJzv6KysyvPSOtFuUTbng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-11 0:07 ` Jianqun
2014-07-11 0:07 ` Jianqun
2014-07-11 0:13 ` Jianqun
[not found] ` <53BF2AB8.7050307-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-11 0:32 ` Stephen Rothwell
2014-07-11 0:32 ` Stephen Rothwell
2014-07-11 12:42 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711124231.GN30458@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jim.epost@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
--cc=xjq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.