All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, brogers@suse.com
Subject: Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types
Date: Fri, 11 Jul 2014 21:06:57 +0300	[thread overview]
Message-ID: <20140711180657.GA1439@redhat.com> (raw)
In-Reply-To: <1404826186-15146-1-git-send-email-imammedo@redhat.com>

On Tue, Jul 08, 2014 at 03:29:46PM +0200, Igor Mammedov wrote:
> If machine doesn't support memory hotplug then staring QEMU
> with initial memory less than default will make QEMU exit with
> following error message:
> 
> $QEMU -m 16  -M isapc
> qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc
> 
> Set maxram_size to initial memory value before parsing
> 'maxmem' option allows to keep maxmem in sync with initial
> memory size if no maxmem option was specified.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> CC: Bruce Rogers <brogers@suse.com>

OK this is a regression fix so we need it for 2.1.

Applied, thanks!

> ---
>  vl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index 6e084c2..6abedcf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3315,6 +3315,7 @@ int main(int argc, char **argv, char **envp)
>                      error_report("ram size too large");
>                      exit(EXIT_FAILURE);
>                  }
> +                maxram_size = ram_size;
>  
>                  maxmem_str = qemu_opt_get(opts, "maxmem");
>                  slots_str = qemu_opt_get(opts, "slots");
> -- 
> 1.8.5.2 (Apple Git-48)

  reply	other threads:[~2014-07-11 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 13:29 [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types Igor Mammedov
2014-07-11 18:06 ` Michael S. Tsirkin [this message]
2014-07-17 14:32   ` Bruce Rogers
2014-07-17 15:46 ` Bruce Rogers
2014-07-18  8:34   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140711180657.GA1439@redhat.com \
    --to=mst@redhat.com \
    --cc=brogers@suse.com \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.