From: Andi Kleen <andi@firstfloor.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext
Date: Fri, 11 Jul 2014 20:12:12 +0200 [thread overview]
Message-ID: <20140711181212.GT18735@two.firstfloor.org> (raw)
In-Reply-To: <a13ebdd57378120348f40cbe12d9b1705d189434.1405095200.git.luto@amacapital.net>
> diff --git a/arch/x86/include/uapi/asm/sigcontext.h b/arch/x86/include/uapi/asm/sigcontext.h
> index 076b11f..df9908b 100644
> --- a/arch/x86/include/uapi/asm/sigcontext.h
> +++ b/arch/x86/include/uapi/asm/sigcontext.h
I don't think renaming fields in uapi/asm is acceptable. These
are likely used by user programs and you'll break compiles.
-Andi
> @@ -177,8 +177,8 @@ struct sigcontext {
> __u64 rip;
> __u64 eflags; /* RFLAGS */
> __u16 cs;
> - __u16 gs;
> - __u16 fs;
> + __u16 __pad2; /* Was called gs, but was always zero. */
> + __u16 __pad1; /* Was called fs, but was always zero. */
> __u16 ss;
> __u64 err;
> __u64 trapno;
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2014-07-11 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 16:29 [PATCH 0/2] x86_64,signal: Fix the set of saved segment registers Andy Lutomirski
2014-07-11 16:29 ` [PATCH 1/2] x86_64,signal: Save and restore SS in signal frames Andy Lutomirski
2015-03-09 20:15 ` Andy Lutomirski
2014-07-11 16:29 ` [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext Andy Lutomirski
2014-07-11 18:12 ` Andi Kleen [this message]
2014-07-11 18:39 ` Andy Lutomirski
2014-07-12 2:09 ` H. Peter Anvin
2014-07-12 2:04 ` H. Peter Anvin
2014-07-12 2:21 ` Linus Torvalds
2014-07-12 2:26 ` H. Peter Anvin
2014-07-12 8:39 ` Andy Lutomirski
2014-07-12 18:37 ` Andi Kleen
2014-07-12 18:40 ` H. Peter Anvin
2014-07-12 18:52 ` Andi Kleen
2014-07-12 21:17 ` Andy Lutomirski
2014-07-18 1:13 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711181212.GT18735@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=viro@ZenIV.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.