From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [RFC PATCH v2 1/7] Removed all code from sedf not
 needed for basic EDF functionality
Date: Fri, 11 Jul 2014 15:54:14 -0400
Message-ID: <20140711195414.GM23257@laptop.dumpdata.com>
References: <1404939348-4926-1-git-send-email-josh.whitehead@dornerworks.com>
	<1404939348-4926-2-git-send-email-josh.whitehead@dornerworks.com>
	<1405062327.29306.292.camel@Solace>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1405062327.29306.292.camel@Solace>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, Xen-devel <xen-devel@lists.xen.org>, Nathan Studer <nate.studer@gmail.com>, Josh Whitehead <josh.whitehead@dornerworks.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 11, 2014 at 09:05:27AM +0200, Dario Faggioli wrote:
> On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> > A large amount of code had been added to the sedf scheduler over the years that
> > had made it everything but a "simple" EDF scheduler.
> >
> Indeed! :-)
> 
> > --- a/xen/common/sched_sedf.c
> > +++ b/xen/common/sched_sedf.c
>  
> > -#define EXTRA_NONE (0)
> > -#define EXTRA_AWARE (1)
> > -#define EXTRA_RUN_PEN (2)
> > -#define EXTRA_RUN_UTIL (4)
> > -#define EXTRA_WANT_PEN_Q (8)
> > -#define EXTRA_PEN_Q (0)
> > -#define EXTRA_UTIL_Q (1)
> >  #define SEDF_ASLEEP (16)
> >
> As said when reviewing other patches in the series, do not limit to
> removing the flags, do also "renumber" the remaining one, instead of
> living it #defined to 16.
> 
> I can clearly see someone looking at the code rather puzzled about why,
> since there is only one flag, it is associated to the 5th bit! :-P
> 
> The rest of this patch looks fine to me.

Is that an 'Reviewed-by' or 'Acked-by' ?

Thank you.
> 
> Regards,
> Dario
> 
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> 



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel