From: Daniel Vetter <daniel@ffwll.ch>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [v3 09/13] drm/i915: Add rotation property for sprites
Date: Sat, 12 Jul 2014 00:10:40 +0200 [thread overview]
Message-ID: <20140711221040.GL17271@phenom.ffwll.local> (raw)
In-Reply-To: <1404795723-9630-10-git-send-email-sonika.jindal@intel.com>
On Tue, Jul 08, 2014 at 10:31:59AM +0530, sonika.jindal@intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Sprite planes support 180 degree rotation. The lower layers are now in
> place, so hook in the standard rotation property to expose the feature
> to the users.
>
> v2: Moving rotation_property to drm_plane
>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 40 ++++++++++++++++++++++++++++++++++-
> include/drm/drm_crtc.h | 1 +
One more: A patch titled with "drm/i915: ..." really shouldn't touch
anything outside of drm/i915 directories and so shouldn't introduce any
changes to core drm code. Such changes always need to be split out into a
separate drm patch. Exceptions (like refactoring function interfaces)
obviously apply.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-11 22:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 5:01 [v3 00/13] Support for 180 degree HW rotation sonika.jindal
2014-07-08 5:01 ` [v3 01/13] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sonika.jindal
2014-07-08 5:01 ` [v3 02/13] drm: Add support_bits parameter to drm_property_create_bitmask() sonika.jindal
2014-07-08 5:01 ` [v3 03/13] drm: Add drm_mode_create_rotation_property() sonika.jindal
2014-07-08 5:01 ` [v3 04/13] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sonika.jindal
2014-07-08 5:01 ` [v3 05/13] drm: Add drm_rect rotation functions sonika.jindal
2014-07-08 5:01 ` [v3 06/13] drm: Add drm_rotation_simplify() sonika.jindal
2014-07-08 5:01 ` [v3 07/13] drm/i915: Add 180 degree sprite rotation support sonika.jindal
2014-07-08 5:01 ` [v3 08/13] drm/i915: Make intel_plane_restore() return an error sonika.jindal
2014-07-08 5:01 ` [v3 09/13] drm/i915: Add rotation property for sprites sonika.jindal
2014-07-11 21:59 ` [Intel-gfx] " Daniel Vetter
2014-07-14 3:57 ` Jindal, Sonika
2014-07-11 22:06 ` [Intel-gfx] " Daniel Vetter
2014-07-11 22:10 ` Daniel Vetter [this message]
2014-07-08 5:02 ` [v3 10/13] drm/i915: Add 180 degree primary plane rotation support sonika.jindal
2014-07-08 5:02 ` [v3 11/13] drm: Resetting rotation property sonika.jindal
2014-07-08 5:02 ` [v3 12/13] Documentation: drm: Removing placeholders for generic drm properties description sonika.jindal
2014-07-08 5:02 ` [v3 13/13] Documentation: drm: describing rotation property for i915 sonika.jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711221040.GL17271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.