From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] Low hanging fruit to reduce the driver size
Date: Sat, 12 Jul 2014 13:01:42 +0200 [thread overview]
Message-ID: <20140712110142.GU17271@phenom.ffwll.local> (raw)
In-Reply-To: <1405100054-5974-1-git-send-email-damien.lespiau@intel.com>
On Fri, Jul 11, 2014 at 06:34:12PM +0100, Damien Lespiau wrote:
> Being able to target a single platform to reduce the driver size has been
> voiced a few times. These patches provide a Kconfig option to provide the
> opportunity.
>
> Let's start small, and, along side the generic "Multi-platform" option, only
> present Haswell and Broadwell in the list of platforms to choose from. When
> selecting any of those those two platforms, (S)DVO and MIPI DSI code is not
> compiled.
>
> The driver .text size is reduced by 67Kb (8.8%) when selecting HSW/BDW.
Iirc my poor-man's-lto (include everything into one file) hack with a
similar scenario and hard-coding intel_info plus adding a few hacks to
help along gcc saved around 20-25% percent.
And I'm really not terribly convinced that kb shaving is worth the effort
overall, especially if it comes at a fairly steep maintainance burden of
piles of new config options and #defines.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-12 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 17:34 [PATCH 0/2] Low hanging fruit to reduce the driver size Damien Lespiau
2014-07-11 17:34 ` [PATCH 1/2] drm/i915: Provide a config option to select a target platform Damien Lespiau
2014-07-14 10:18 ` Barbalho, Rafael
2014-07-14 10:40 ` Damien Lespiau
2014-07-11 17:34 ` [PATCH 2/2] drm/i915: Don't compile the MIPI DSI code on HSW/BDW Damien Lespiau
2014-07-11 18:34 ` [PATCH 0/2] Low hanging fruit to reduce the driver size Damien Lespiau
2014-07-12 11:01 ` Daniel Vetter [this message]
2014-07-12 11:11 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712110142.GU17271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.