From: Dave Jones <davej@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: i915: reduce noise from i915_gem_shrinker_oom when no memory freed.
Date: Sat, 12 Jul 2014 11:50:25 -0400 [thread overview]
Message-ID: <20140712155025.GA2122@redhat.com> (raw)
In-Reply-To: <20140712092343.GO17271@phenom.ffwll.local>
On Sat, Jul 12, 2014 at 11:23:43AM +0200, Daniel Vetter wrote:
> On Fri, Jul 11, 2014 at 07:11:43AM +0100, Chris Wilson wrote:
> > On Thu, Jul 10, 2014 at 11:05:05PM -0400, Dave Jones wrote:
> > > When the shrinker doesn't free any memory, don't spew over and over
> > > into the logs. My fuzz tester hits this quite easily, resulting
> > > in dozens of instances of this printk when memory runs low, filling
> > > dmesg, when there's not even any graphical stuff going on, so the
> > > situation would never change.
> >
> > We still want to know when we failed to free anything though.
> >
> > if (freed || unbound || bound)
> > pr_info("Purging GPU memory...
> >
> > should be a reasonable compromise.
>
> Dave, would this work for you? Can you please submit it as a patch to
> intel-gfx?
Will do when I get back on Monday. I'm running my tests over the
weekend, looks ok so far.
thanks,
Dave
prev parent reply other threads:[~2014-07-12 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 3:05 i915: reduce noise from i915_gem_shrinker_oom when no memory freed Dave Jones
2014-07-11 6:11 ` Chris Wilson
2014-07-12 9:23 ` Daniel Vetter
2014-07-12 15:50 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712155025.GA2122@redhat.com \
--to=davej@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.