All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: checkpatch.pl misses list_for_each_entry() coding style issues
Date: Sat, 12 Jul 2014 16:08:28 -0700	[thread overview]
Message-ID: <20140712230828.GA15827@kroah.com> (raw)

Hi Joe,

The following function:

$ cat foo.c 

static int foo_init(void)
{

	list_for_each_entry(foo, &foo, list)
	{
		do_something_foo(foo);
	}

	return 0;
}

Will not be caught by checkpatch:

$ ./scripts/checkpatch.pl --file foo.c 
total: 0 errors, 0 warnings, 11 lines checked

foo.c has no obvious style problems and is ready for submission.


Any way to fix that up?

thanks,

greg k-h

             reply	other threads:[~2014-07-12 23:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 23:08 Greg KH [this message]
2014-07-13  3:10 ` checkpatch.pl misses list_for_each_entry() coding style issues Joe Perches
2014-07-13  5:33 ` [PATCH] checkpatch: Add for_each tests to indentation and brace tests Joe Perches
2014-07-14  8:13   ` Andy Whitcroft
2014-07-14  8:18     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140712230828.GA15827@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.