From: Dave Chinner <david@fromorbit.com>
To: Samuel Just <sam.just@inktank.com>
Cc: Ilya Dryomov <ilya.dryomov@inktank.com>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
Sage Weil <sage@inktank.com>,
xfs@oss.sgi.com
Subject: Re: consequences of XFS_IOC_FSSETXATTR on non-empty file?
Date: Sun, 13 Jul 2014 11:26:24 +1000 [thread overview]
Message-ID: <20140713012624.GS4453@dastard> (raw)
In-Reply-To: <CA+4uBUYg+81G2=sj3qXO4GGgA7pyjgVrGDCN+UQ32jnWgSbG5w@mail.gmail.com>
On Sat, Jul 12, 2014 at 06:16:54PM -0700, Samuel Just wrote:
> Hi,
>
> We are seeing reports of ceph-osd stores on xfs of files with some
> garbage data (possibly misplaced from data elsewhere in the
> filesystem). There was a bug for a while where the ceph-osd process
> would set a value for fsx_extsize on a non-empty (possibly sparse)
> file using XFS_IOC_FSSETXATTR. Could that plausibly result in a file
> with garbage data?
No, setting an extent size on a non-empty file will simply fail
with EINVAL.
Do you have any method of reproducing the bad data in files?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-13 1:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 1:16 consequences of XFS_IOC_FSSETXATTR on non-empty file? Samuel Just
2014-07-13 1:16 ` Samuel Just
2014-07-13 1:26 ` Dave Chinner [this message]
2014-07-13 1:48 ` Samuel Just
2014-07-13 1:48 ` Samuel Just
2014-07-13 17:01 ` Ilya Dryomov
2014-07-13 22:55 ` Dave Chinner
2014-07-13 22:55 ` Dave Chinner
2014-07-14 7:24 ` Ilya Dryomov
2014-07-14 7:24 ` Ilya Dryomov
2014-07-14 20:23 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140713012624.GS4453@dastard \
--to=david@fromorbit.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
--cc=sage@inktank.com \
--cc=sam.just@inktank.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.