From: "Michael S. Tsirkin" <mst@redhat.com>
To: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Cc: kwolf@redhat.com, snabb-devel@googlegroups.com,
qemu-devel@nongnu.org, tech@virtualopensystems.com
Subject: Re: [Qemu-devel] [PATCH] qtest: fix vhost-user-test compilation with old GLib
Date: Mon, 14 Jul 2014 01:26:34 +0300 [thread overview]
Message-ID: <20140713222634.GB8804@redhat.com> (raw)
In-Reply-To: <20140709150442.6843.14602.stgit@3820>
On Wed, Jul 09, 2014 at 06:06:32PM +0300, Nikolay Nikolaev wrote:
> Mising G_TIME_SPAN_SECOND definition breaks the RHEL6 compilation as GLib
> version before 2.26 does not have it. In such case just define it.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Applied, thanks!
> ---
> tests/vhost-user-test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index b9dcec1..75fedf0 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -22,6 +22,10 @@
> #include <qemu/sockets.h>
>
> /* GLIB version compatibility flags */
> +#if !GLIB_CHECK_VERSION(2, 26, 0)
> +#define G_TIME_SPAN_SECOND (G_GINT64_CONSTANT(1000000))
> +#endif
> +
> #if GLIB_CHECK_VERSION(2, 28, 0)
> #define HAVE_MONOTONIC_TIME
> #endif
next prev parent reply other threads:[~2014-07-13 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 15:06 [Qemu-devel] [PATCH] qtest: fix vhost-user-test compilation with old GLib Nikolay Nikolaev
2014-07-09 16:28 ` Kevin Wolf
2014-07-13 22:26 ` Michael S. Tsirkin [this message]
2014-07-13 22:27 ` Michael S. Tsirkin
2014-07-13 23:08 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140713222634.GB8804@redhat.com \
--to=mst@redhat.com \
--cc=kwolf@redhat.com \
--cc=n.nikolaev@virtualopensystems.com \
--cc=qemu-devel@nongnu.org \
--cc=snabb-devel@googlegroups.com \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.