Re: [PATCH char-misc-next v3 3/8] dma: MIC X100 DMA Driver

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Jul 14, 2014 at 10:07:23AM +0200, Paul Bolle wrote:
> On Fri, 2014-07-11 at 14:04 -0700, Sudeep Dutt wrote:
> > From: Siva Yerramreddy <yshivakrishna@gmail.com>
> > 
> > This patch implements DMA Engine API for DMA controller on MIC X100
> > Coprocessors. DMA h/w is shared between host and card s/w.
> > Channels 0 to 3 are used by host and 4 to 7 are used by card.
> > Since the DMA device doesn't show up as PCIe device, a virtual bus called mic
> > bus is created and virtual devices are added on that bus to follow device model.
> > Allowed dma transfer directions are host to card, card to host and card to card.
> > 
> > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
> > Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com>
> > Signed-off-by: Siva Yerramreddy <yshivakrishna@gmail.com>
> > ---
> >  drivers/dma/Kconfig        |  19 ++
> >  drivers/dma/Makefile       |   1 +
> >  drivers/dma/mic_x100_dma.c | 774 +++++++++++++++++++++++++++++++++++++++++++++
> >  drivers/dma/mic_x100_dma.h | 286 +++++++++++++++++
> >  4 files changed, 1080 insertions(+)
> >  create mode 100644 drivers/dma/mic_x100_dma.c
> >  create mode 100644 drivers/dma/mic_x100_dma.h
> 
> This patch was first included in linux-next in next-20140714.
> 
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index 1eca7b9..7c8b8c4 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -33,6 +33,25 @@ if DMADEVICES
> >  
> >  comment "DMA Devices"
> >  
> > +config INTEL_MIC_X100_DMA
> > +	tristate "Intel MIC X100 DMA Driver"
> > +	depends on 64BIT && X86 && INTEL_MIC_BUS
> > +	select DMAENGINE
> 
> You probably meant
>          select DMA_ENGINE
> 
> > +	default N
> 
> That should have been "default n". As (lowercase) "n" is the default
> anyhow, that line might as well be dropped.
> 
> > +	help
> > +	  This enables DMA support for the Intel Many Integrated Core
> > +	  (MIC) family of PCIe form factor coprocessor X100 devices that
> > +	  run a 64 bit Linux OS. This driver will be used by both MIC
> > +	  host and card drivers.
> > +
> > +	  If you are building host kernel with a MIC device or a card
> > +	  kernel for a MIC device, then say M (recommended) or Y, else
> > +	  say N. If unsure say N.
> > +
> > +	  More information about the Intel MIC family as well as the Linux
> > +	  OS and tools for MIC to use with this driver are available from
> > +	  <http://software.intel.com/en-us/mic-developer>.
> > +
> >  config INTEL_MID_DMAC
> >  	tristate "Intel MID DMA support for Peripheral DMA controllers"
> >  	depends on PCI && X86
> 
> Should I submit the trivial, but untested, patch to fix this or do you
> prefer to do that yourself?

You can send it :)

thanks,

greg k-h